Page MenuHomePhabricator

Database: DatabaseBase::query should not write mangled binary blob to debug log
Closed, ResolvedPublic

Description

Often when debugging something the debug log has massive blobs in it one has to scroll over. These have no value and should be omitted or filtered out.

Sample

Fully initialised
Connected to database 0 at localhost
Connected to database 0 at localhost
DatabaseBase::query: Writes done: INSERT IGNORE INTO msg_resource (mr_lang,mr_resource,mr_blob,mr_timestamp) VALUES ('en','jquery.checkboxShiftClick','{}','20140701185106')
Unstubbing $wgLang on call of $wgLang::getCode from Message::inLanguage
User: got user 1 from cache
User: loading options for user 1 from override cache.
User: logged in from session
User: loading options for user 1 from override cache.
MessageCache::load: Loading en... got from local cache
DatabaseBase::query: Writes done: REPLACE INTO objectcache (keyname,value,exptime) VALUES ('alphawiki:resourceloader:filter:minify-js:7:f2e14537823b6d6224056b2250fe3474','?}?{۶????+d...<snip>...2x?ptt?0??O ?-? ','20380119031407')
wfClientAcceptsGzip: client accepts gzip.
wfGzipHandler() is compressing output


Version: unspecified
Severity: normal

Details

Reference
bz67382

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz67382.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle created this task.Jul 1 2014, 6:55 PM

Change 143384 had a related patch set uploaded by Krinkle:
Database: Generalise SQL before writing to debug log

https://gerrit.wikimedia.org/r/143384

Change 143384 merged by jenkins-bot:
Database: Generalise SQL before writing to debug log

https://gerrit.wikimedia.org/r/143384