Page MenuHomePhabricator

"Maximum execution time" error in JavaScriptMinifier while minifying QUnit test modules
Closed, ResolvedPublic

Description

It might possible to make this less likely by grouping them into smaller requests.

The request is:


http://127.0.0.1:8080/w/load.php?debug=false&lang=en&modules=Base64.js%7Ceasy-deflate.core%2Cdeflate%7Cext.eventLogging%2Cmantle%7Cext.eventLogging.tests%7Cext.flow.new.handlebars.tests%7Cext.flow.new.tests%7Cext.gettingstarted.user%7Cext.gettingstarted.user.tests%7Cext.guidedTour.lib%2Cstyles%7Cext.guidedTour.lib.internal%2Ctests%7Cext.mantle.handlebars%2Ctemplates%7Cext.templateData.test%7Cext.templateDataGenerator.core%7Cext.visualEditor.base%2Ccore%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwreference%2Cmwtransclusion%2Cstandalone%2Ctest%2CviewPageTarget%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwimage.core%7Cext.visualEditor.viewPageTarget.init%7Cjquery.accessKeyLabel%2CautoEllipsis%2CbyteLength%2CbyteLimit%2CcheckboxShiftClick%2Cclient%2Ccookie%2CgetAttrs%2ChighlightText%2Ci18n%2Cjson%2CmakeCollapsible%2Cmw-jump%2CmwExtension%2Cplaceholder%2Cqunit%2CtabIndex%2Cthrottle-debounce%2CvisibleText%7Cjquery.qunit.completenessTest%7Cjquery.uls.data%7Cmediawiki.Title%2CUri%2Capi%2Ccldr%2Cfeedback%2CjqueryMsg%2Clanguage%2Cnotify%2Cuser%2Cutil%7Cmediawiki.api.edit%7Cmediawiki.language.init%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.libs.guiders%2Cpluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.special.javaScriptTest%7Cmediawiki.ui.button%7Coojs%2Coojs-ui%2Crangy%7Cskins.vector.js%7Ctest.mediawiki.qunit.testrunner%7Ctest.sinonjs%7Cunicodejs.wordbreak&skin=vector&version=20140701T185441Z&*


The error response is:

Fatal error: Maximum execution time of 30 seconds exceeded in /vagrant/mediawiki/includes/libs/JavaScriptMinifier.php on line 428

Call Stack:

0.0021     656184   1. {main}() /vagrant/mediawiki/load.php:0
0.2177   10838400   2. ResourceLoader->respond() /vagrant/mediawiki/load.php:43
0.4901   11686616   3. ResourceLoader->makeModuleResponse() /vagrant/mediawiki/includes/resourceloader/ResourceLoader.php:543
2.1315   19034048   4. ResourceLoader->filter() /vagrant/mediawiki/includes/resourceloader/ResourceLoader.php:923
2.1480   19272904   5. JavaScriptMinifier::minify() /vagrant/mediawiki/includes/resourceloader/ResourceLoader.php:181

Version: unspecified
Severity: normal

Details

Reference
bz67383

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:42 AM
bzimport set Reference to bz67383.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle set Security to None.

I'm hitting this issue now in my local vagrant - this really shouldn't be taking 30 seconds to load should it even if it's a big file..?

This might be improved by enabling fsc caching for the VM: vagrant config nfs_cache yes; vagrant reload

@dduvall and I would love feedback from power users on the pros/cons of using the fsc nfs cache.

Krinkle claimed this task.