bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz67387.
Steinsplitter created this task.Via LegacyJul 1 2014, 7:41 PM
tomasz added a comment.Via ConduitJul 1 2014, 7:45 PM

Raising importance since that's a very critical bug that's blocking hundreds (thousands?) of uploads on Commons right now.

SPQRobin added a comment.Via ConduitJul 1 2014, 7:52 PM

(In reply to Krinkle from comment #2)

Likely caused by
https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/
c6e84ba3

That was supposed to fix it.

Krinkle added a comment.Via ConduitJul 1 2014, 7:53 PM

In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but caused this as a regression.

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be backported to 1.24wmf11.

Reedy added a comment.Via ConduitJul 1 2014, 7:53 PM

(In reply to Krinkle from comment #2)

Likely caused by
https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/
c6e84ba3

Caused by? It was the commit to make it content language (not user language), which was backported and deployed to the cluster?

https://gerrit.wikimedia.org/r/#/q/Ife55252fa3a8c575d13c41420814f42b914aa90d,n,z

Reedy added a comment.Via ConduitJul 1 2014, 7:55 PM

(In reply to Krinkle from comment #4)

In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but
caused this as a regression.

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be
backported to 1.24wmf11.

https://gerrit.wikimedia.org/r/142384

https://gerrit.wikimedia.org/r/142387

Krinkle added a comment.Via ConduitJul 1 2014, 7:55 PM

(In reply to Krinkle from comment #4)

In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but
caused this as a regression.

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be
backported to 1.24wmf11.

Was already backported as 650ce038a86ee8408861 5 days ago. Guess that didn't fix it.

Reedy added a comment.Via ConduitJul 1 2014, 7:56 PM

reedy@mw1017:/usr/local/apache/common/php-1.24wmf11/extensions/WikimediaMessages$ grep "UploadForm:initial" WikimediaMessages.php -A 10
$wgHooks['UploadForm:initial'][] = function() {

if ( wfMessage( 'licenses' )->inContentLanguage()->isDisabled() ) {
        throw new ErrorPageError( 'uploaddisabled', 'wikimedia-upload-nolicenses' );
}

};

SPQRobin added a comment.Via ConduitJul 1 2014, 7:58 PM

It works on all other wikis, so there appears to be somehow something Commons-specific...

SPQRobin added a comment.Via ConduitJul 1 2014, 8:03 PM

I see the problem, Commons is one of the few wikis with 'licenses' in $wgForceUIMsgAsContentMsg.

gerritbot added a comment.Via ConduitJul 1 2014, 8:11 PM

Change 143396 had a related patch set uploaded by SPQRobin:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143396

gerritbot added a comment.Via ConduitJul 1 2014, 8:25 PM

Change 143396 merged by jenkins-bot:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143396

gerritbot added a comment.Via ConduitJul 1 2014, 8:25 PM

Change 143403 had a related patch set uploaded by Reedy:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143403

gerritbot added a comment.Via ConduitJul 1 2014, 8:27 PM

Change 143403 merged by jenkins-bot:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143403

Steinsplitter added a comment.Via ConduitJul 1 2014, 8:39 PM

Works now. Thanks for fixing the bug so fast. :-)

tomasz added a comment.Via ConduitJul 1 2014, 8:43 PM

Verified to work. Thanks again, guys.

Add Comment