[Task] Make Hovercards work on Wikidata item links
Open, NormalPublic

Description

When hovering over a link to an item the hover card should show up. It should show an image if available as well as the label, description and alias.

Currently hovercards don't show up because they can't deal with the JSON we have in the items.

@Vibhabamba: You wanted to make mockups for this. Is there anything you can show already?

Details

Reference
bz67434
bzimport set Reference to bz67434.
bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.Feb 16 2015, 5:43 PM
Prtksxna set Security to None.
Quiddity changed the title from "make hover cards work on item links" to "Make Hovercards work on Wikidata item links".Feb 22 2015, 10:55 PM
Quiddity edited the task description. (Show Details)
Se4598 added a subscriber: Se4598.Feb 22 2015, 11:04 PM

related bug: garbage is displayed in the hovercards for some wikidata links instead of nothing: T78825: Popup/Hover on Wikidata Q pages shows plain /*<![CDATA[*/ only

SamB added a comment.Apr 10 2015, 10:36 PM

Well, it seems to mostly work all of a sudden (any idea why?); it just needs to include the label/aliases and work also on links in main/property namespaces. (Yes, sometimes the label will be redundant, but not always.)

SamB awarded a token.Apr 10 2015, 10:38 PM

@SamB: @Bene made it work with a local hack.

Nifty! It partially works in Q pages, eg


(at https://www.wikidata.org/wiki/Q14649096 showing a Hovercard for https://www.wikidata.org/wiki/Property:P460 )
But it doesn't work in RecentChanges/Watchlists yet.

Here are the useful links from T78825:

@Bene Can you list what you think is still missing before we can take this out of beta features for Wikidata? I have the ok from Vibha to do it on Wikidata.

Bene added a comment.Jun 1 2015, 5:40 PM

If you are ok with enabling this while having it depend on a local hack on Wikidata, we can just enable it right away. However, https://www.wikidata.org/wiki/MediaWiki:Gadget-Descriptions.js has to be removed then as it conflicts with the hovercards.

For a proper integration of Hovercards within Wikibase itself, I'm still waiting for a patch by @Prtksxna as discussed on the hackathon.

https://www.wikidata.org/wiki/MediaWiki:Gadget-Descriptions.js has to be removed then as it conflicts with the hovercards.

Why? It just needs to not be enabled at the same time. And personally I find it subtler than Popups.

Bene added a comment.Jun 2 2015, 10:36 AM

@Ricordisamoa is there an option to opt out from hovercards and can we somehow get that information in the gadget?

@Ricordisamoa is there an option to opt out from hovercards and can we somehow get that information in the gadget?

It's mw.user.options.get('popups') so far.

hoo raised the priority of this task from "Normal" to "High".Jun 18 2015, 12:47 PM

This is apparently "done" by a gadget now: https://www.wikidata.org/wiki/MediaWiki:Gadget-PopupsFix.js We should try to get rid of that fast.

@Bene and I discussed this during the hackathon and came to the conclusion that certain changes need to be made in the way new renderers are registered. One of the architectures we discussed removed the need to make any changes to Properties.

I am yet to submit a patch with these changes and hope to get it done by July.

Sherah: Subscribing you for FYI
Ryan: Subscribing you since I saw your team is looking into navigation popups and hovercards so wanted you to be aware that we want to get it out of beta features on Wikidata.

Change 232236 had a related patch set uploaded (by Prtksxna):
Check renderers' matcher method to find the appropriate renderers for a link

https://gerrit.wikimedia.org/r/232236

Bene changed the title from "Make Hovercards work on Wikidata item links" to "[Task] Make Hovercards work on Wikidata item links".Sep 2 2015, 6:22 PM
Jdlrobson lowered the priority of this task from "High" to "Normal".Sep 25 2015, 4:47 PM
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson changed the task status from "Open" to "Stalled".Sep 28 2015, 3:50 PM

Is this still being worked on? Reading web is shifting its attention to Hovercards soon so it would be great to reboot this work if it has stalled which it seems to have ... :)

Lydia_Pintscher changed the task status from "Stalled" to "Open".Sep 28 2015, 3:52 PM

It is still important for Wikidata. Bene is waiting for Prtksxna to review patches etc.

Which patches..? The only patches I see are from @Prtksxna and he's not responding to code review for a minor fix [1]. Unless I hear from @Prtksxna or @Bene wants to take over the patch it's stalled....

[1] https://gerrit.wikimedia.org/r/232236

Jdlrobson changed the task status from "Open" to "Stalled".Sep 30 2015, 5:43 PM

Please change back to open when one of the above happens.

hoo changed the task status from "Stalled" to "Open".Oct 1 2015, 8:58 AM
Jdlrobson changed the task status from "Open" to "Stalled".Oct 9 2015, 12:48 AM

I need some tests or an example patch making use of this before I can +2 so I can see that it has the desired effect.

Change 232236 merged by jenkins-bot:
Check renderers' matcher method to find the appropriate renderers for a link

https://gerrit.wikimedia.org/r/232236

kaldari removed a subscriber: kaldari.Oct 14 2015, 4:29 PM
Lydia_Pintscher changed the task status from "Stalled" to "Open".Feb 19 2016, 9:54 AM
Prtksxna removed a subscriber: Prtksxna.May 18 2016, 3:41 AM

New feedback from a user, confused by Hovercards behavior.

We have a gadget that made them work on Wikidata, this one needs to be adjusted to the recent refactor of the hovercards.

Change 349130 had a related patch set uploaded (by Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Create IParserContentFormatter for using different formatting engines

https://gerrit.wikimedia.org/r/349130