Empty elements in DOM: PHP parser+tidy strips them; Parsoid doesn't
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	ssastry
	Jul 3 2014, 4:32 AM

Description

The infobox in itwiki:Luna has several empty rows "....|-\n|-\n....". PHP parser + Tidy combo strips them whereas Parsoid doesn't. This causes rendering visual diffs on itwiki:Luna

Reproducible with a simple test case: "{|\n|-\n|-\n|-\n|foo\n}"

What is the right behavior here?

Version: unspecified
Severity: normal

Details

Reference: bz67452

Related Objects
Search...

Status	Assigned	Task
Declined	ssastry	T69452 Empty elements in DOM: PHP parser+tidy strips them; Parsoid doesn't
Resolved	tstarling	T89331 Replace HTML4 Tidy in MW parser with an equivalent HTML5 based tool
Resolved	ssastry	T120345 Set up mass visual diff testing with a custom install of mediawiki
Resolved	bd808	T125882 Create labs project for parsing team to run experimental mediawiki installs
Resolved	ssastry	T134423 Deprecate nonstandard behavior of self-closed HTML tags in wikitext.
Resolved	cscott	T136652 Add tracking category to pages that use deprecated Tidy-specific self-closing tags (<b />, <div />, etc.)
Declined	tstarling	T136668 Puppetize HTML5Depurate
Resolved	tstarling	T136669 Merge mediawiki.raggett.css into other CSS + remove conditional enabling for Tidy
Resolved	• Elitre	T145530 Support the Parsing team with the "Remove Tidy dependency from MediaWiki output" goal
Declined	None	T155634 Tidy strips whitespace after HTML tags AND adds newlines between HTML tags
Resolved	ssastry	T175099 PHP-parser + Remex combo output differs from PHP-parser + Tidy combo on some dl-dt wikitext snippets
Resolved	Jdforrester-WMF	T185753 MediaWiki should default to using RemexHtml for tidy
Resolved	ssastry	T188167 Run parser tests with RemexHtml as the tidy implementation
Resolved	Jdforrester-WMF	T191670 Determine future of MWTidy::checkErrors in a Remex world

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:29 AM

• bzimport added a project: Parsoid.

• bzimport set Reference to bz67452.

ssastry created this task.Jul 3 2014, 4:32 AM

See https://gerrit.wikimedia.org/r/#/c/155348/ for a WIP patch.

This patch is now merged .. the only remaining issue are empty elements found in top-level content. We are going to leave them behind for now so that editors can edit them in VE (rather than hide them and make them uneditable) and maybe delete them.

Arlolra raised the priority of this task from Lowest to Medium.Nov 25 2014, 8:20 PM

Arlolra subscribed.

ssastry moved this task from Needs Triage to Robustness on the Parsoid board.Dec 22 2014, 12:36 AM

ssastry mentioned this in T52976: Image inside a table incorrectly removes a </span> tag.Feb 3 2015, 9:49 PM

• RobLa-WMF added a project: Parsoid-Robustness.Feb 11 2015, 6:12 PM

• marcoil moved this task from Robustness to Needs Triage on the Parsoid board.Feb 13 2015, 12:48 PM

ssastry mentioned this in T89331: Replace HTML4 Tidy in MW parser with an equivalent HTML5 based tool.Feb 13 2015, 3:37 PM

Ricordisamoa subscribed.Aug 13 2015, 4:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 4:50 PM

ssastry added a subtask: T89331: Replace HTML4 Tidy in MW parser with an equivalent HTML5 based tool.May 27 2016, 11:30 PM

Jdforrester-WMF closed subtask T89331: Replace HTML4 Tidy in MW parser with an equivalent HTML5 based tool as Resolved.Apr 13 2018, 3:09 AM

Tidy was responsible for this. RemexHtml doesn't. At this point, both RemexHtml and Parsoid leave empty elements behind but tag empty trs and lis with a mw-empty-elt css class for skins to suppress them.

Empty elements in DOM: PHP parser+tidy strips them; Parsoid doesn'tClosed, DeclinedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Empty elements in DOM: PHP parser+tidy strips them; Parsoid doesn't
Closed, DeclinedPublic
Actions

Related Objects
Search...