Page MenuHomePhabricator

Loading es5-shim module causes error in IE <= 8
Closed, ResolvedPublic

Description

Apparently I2556b39d did not really add v3.4.0 of es5-shim but rather a newer version affected by https://github.com/es-shims/es5-shim/issues/253. This makes es5-shim unusable for its primary purpose in MediaWiki: providing compatibility with old versions of IE.

I ran into this bug, which causes errors even for (non-core) site JS, while working on a user script on English Wikipedia.


Version: 1.24rc
Severity: normal
See Also:
https://github.com/es-shims/es5-shim/issues/253

Details

Reference
bz67565

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz67565.

Change 144359 had a related patch set uploaded by PleaseStand:
Update es5-shim to bb74ba2 (2014-06-25)

https://gerrit.wikimedia.org/r/144359

(In reply to Kevin Israel (PleaseStand) from comment #0)

I ran into this bug, which causes errors even for (non-core) site JS, while
working on a user script on English Wikipedia.

I think this is because of MultimediaViewer (see also bug 67590).

My motivation for using es5-shim and reporting this bug, however, is that I have a user script on English Wikipedia that otherwise would need its own date parsing code https://en.wikipedia.org/w/index.php?title=User:PleaseStand/userinfo.js&diff=615803540&oldid=603055971.

Change 144359 merged by jenkins-bot:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/144359

Change 145400 had a related patch set uploaded by Jforrester:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145400

Change 145401 had a related patch set uploaded by Jforrester:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145401

Change 145400 merged by jenkins-bot:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145400

Change 145401 merged by jenkins-bot:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145401

[Backport was merged into 1.24wmf12 and 1.24wmf13 upon a time, hence setting Backport_WMF flag to +]