Page MenuHomePhabricator
Create Task
Maniphest T69568

claimit.py conditionals:only add p:foo if p:bar exists
Closed, ResolvedPublic
Actions

Description

Please Add this feature. Only add a property if another property of claim exists.

Version: core-(2.0)
Severity: enhancement

Details

Reference
bz67568
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add ItemClaimFilterPageGeneratorpywikibot/coremaster+254 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:37 AM
• bzimport added a project: Pywikibot-Wikidata.
• bzimport set Reference to bz67568.
• bzimport added a subscriber: Unknown Object (????).
Matanya created this task.Jul 6 2014, 8:52 PM
JAnD added a comment.Jul 7 2014, 10:48 AM

or add it only if property123 is_not_equal Q456

Aklapper added a project: Pywikibot.Nov 27 2014, 4:20 PM
jayvdb moved this task from Backlog to Data loading problems on the Pywikibot-Wikidata board.Nov 30 2014, 12:08 PM
jayvdb subscribed.Dec 2 2014, 5:36 AM

Can you provide a real example of how this would be used?

JAnD added a comment.EditedDec 2 2014, 7:11 AM

claimit.py -pagegenerators P21 Q6581097 -onlyif:P31=Q5

bot should not add gender to items which are not instance of homo sapiens

valhallasw added a project: Pywikibot-pagegenerators.Dec 2 2014, 8:52 AM
valhallasw subscribed.

I'd suggest implementing this as a Pywikibot-pagegenerators filter.

jayvdb moved this task from Backlog to Generator requests on the Pywikibot-pagegenerators board.Dec 2 2014, 9:17 AM
jayvdb added a comment.Dec 2 2014, 9:25 AM
In T69568#800583, @valhallasw wrote:

I'd suggest implementing this as a Pywikibot-pagegenerators filter.

I agree.

jayvdb added a comment.Dec 3 2014, 3:45 AM

I've proposed this as a GCI coding task: https://www.google-melange.com/gci/task/edit/google/gci2014/5871393535164416 , tentatively naming the new filter "ItemClaimFilterPageGenerator".

jayvdb added a comment.Dec 3 2014, 7:15 AM

T73713 is a very similar problem - there, the script should skip the page/item if it meets certain conditions.

jayvdb mentioned this in T73713: coordinate_import.py should not add coordinates to items about people.Dec 3 2014, 7:16 AM
jayvdb added a project: Google-Code-in-2014.Dec 7 2014, 2:08 AM
jayvdb moved this task from Backlog to pywikibot on the Google-Code-in-2014 board.Dec 7 2014, 2:12 AM
gerritbot added a project: Patch-For-Review.Dec 11 2014, 5:38 PM

Change 179158 had a related patch set uploaded (by M4tx):
Add ItemClaimFilterPageGenerator

https://gerrit.wikimedia.org/r/179158

Patch-For-Review

gerritbot subscribed.Jan 17 2015, 1:11 PM

Change 179158 merged by jenkins-bot:
Add ItemClaimFilterPageGenerator

https://gerrit.wikimedia.org/r/179158

m4tx mentioned this in rPWBCd96a64c8c982: Add ItemClaimFilterPageGenerator.Mar 4 2015, 8:46 AM
jayvdb assigned this task to m4tx.Jan 18 2016, 8:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2016, 8:25 AM
jayvdb mentioned this in T123883: Make Claim.target_equals take precision into account.Jan 18 2016, 8:26 AM
Xqt closed this task as Resolved.May 18 2016, 8:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits