Page MenuHomePhabricator

Ship Object.create polyfill for OOjs for compatibility with browser having ES3 engines
Closed, ResolvedPublic


After installing the MultimediaViewer extension, setting $wgIncludejQueryMigrate = true (bug 66098), and applying the fix for bug 67565, I get the following error in IE 8:

Object doesn't support this property or method
oojs.js, line 89 character 2

targetFn.prototype = Object.create( originFn.prototype, {
// Restore constructor property of targetFn
constructor: {

		value: targetConstructor,
		enumerable: false,
		writable: true,
		configurable: true

} );

Version: 1.24rc
Severity: minor



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:38 AM
bzimport set Reference to bz67590.

This is a bug with MediaWiki core's use of an ES5-only library with a good enough shim, not with the library

Change 156046 had a related patch set uploaded by Krinkle:
es5-shim: Add polyfill for Object.create

Change 156046 merged by jenkins-bot:
es5-shim: Add polyfill for Object.create