Page MenuHomePhabricator

QA tests in mediawiki-core should have no logic or mention of Wikimedia Foundation wikis
Closed, ResolvedPublic

Description

See also https://gerrit.wikimedia.org/r/#/c/143199/

Please refactor these soon so that they take wikis (and ideally browsers as well) via run-time configuration instead of hardcoded in the repository. These should be tests for the feature in general, which (depending on how they are run) can be used as up-time checker or regression indicator for a specific wiki (e.g. wmf production or beta labs). But the test itself should not have that logic in it. that should be provided from the Jenkins job running it.


Version: 1.24rc
Severity: normal

Details

Reference
bz67616

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:40 AM
bzimport set Reference to bz67616.
Krinkle created this task.Jul 7 2014, 6:46 PM

Ideally this code would not make it into a release or stable branch to avoid cluttering third-parties adopting this pattern. Targeting against 1.24 as reminder.

Zeljko and I discussed this today, and we should be able to remove specific environment tags from the feature files when we implement pull-by-branch. This is a high priority for the Release Engineering team, and we have made some progress toward this in the builds already, with Antoine's mw-api-siteinfo.py script added to the Jenkins builds.

Has any progress been made on this?

Chris and I have paired on it today, but ran out of time. If nothing goes wrong, we should be able to clean up Core tomorrow.

Change 163182 had a related patch set uploaded by Zfilipin:
Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163182

Change 162910 had a related patch set uploaded by Zfilipin:
Core browser tests no longer have site specific Cucumber tags

https://gerrit.wikimedia.org/r/162910

Change 163238 had a related patch set uploaded by Legoktm:
QA: Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163238

Change 163182 merged by jenkins-bot:
QA: Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163182

Change 163238 merged by jenkins-bot:
QA: Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163238

Merged and backported!

Change 162910 merged by jenkins-bot:
Core browser tests no longer have site specific Cucumber tags

https://gerrit.wikimedia.org/r/162910