Page MenuHomePhabricator

hide-if boolean combiners no longer work
Closed, ResolvedPublic

Description

When a field has a data-hide-if such as '["OR",["===","foo","bar"],["===","foo","baz"]]', the field is not properly shown or hidden when element "foo" is updated.

git bisect turns up Gerrit change 133254 as the culprit, and reverting the change that patch made to mediawiki.htmlform.js lines 50–69 fixes it. Apparently jQuery does not do the "right" thing when $() is passed an array of jQuery objects.

Timo, do you have a better solution than reverting those lines?


Version: 1.24rc
Severity: normal

Details

Reference
bz67685

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:27 AM
bzimport set Reference to bz67685.
Anomie created this task.Jul 8 2014, 7:38 PM

Change 145350 had a related patch set uploaded by Anomie:
Partially revert Icfe63a41

https://gerrit.wikimedia.org/r/145350

Change 145350 merged by jenkins-bot:
mediawiki.htmlform: Fix broken $() call

https://gerrit.wikimedia.org/r/145350