Page MenuHomePhabricator

Full text search results missing
Closed, ResolvedPublic

Description

Author: jgonera

Description:
If you search in pages content (using button or by pressing Enter), the search results page won't show results due to changes in markup and ours CSS hiding everything. I can reproduce that on beta labs and my local dev instance but not on enwiki (different search engine?).


Version: unspecified
Severity: normal

Details

Reference
bz67740

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz67740.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Jul 9 2014, 6:00 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/HDmKHKry

Confirmed on my private wiki :/ (http://www.droidwiki.de/index.php?search=Root&fulltext=search)

I think it's a new version of cirrussearch (both, beta labs and en uses cirrussearch for elasticsearch integration). I think beta labs (and unhappily me too) uses one of the newer git versions, where something changed.

Ah, and confirmed on MediaWiki.org:
https://m.mediawiki.org/w/index.php?search=Gerrit&fulltext=search
And on Wikitionary (german): https://de.m.wiktionary.org/w/index.php?title=Spezial:Suche&profile=default&search=Test&fulltext=Search

All these wikis changed to wmf12, so maybe this comes with the new WMF deployment (and this turns it to a blocker for me, tomorrow is the planned change to Wikipedias if i'm right).

Caused by (reverted: worked, now publish on my private, so no longer an example :P):
https://gerrit.wikimedia.org/r/#/c/143548/1

(moving to SpecialPage?)

Change 145036 had a related patch set uploaded by Florianschmidtwelzow:
Create valid HTML on Search page

https://gerrit.wikimedia.org/r/145036

Change 145037 had a related patch set uploaded by Florianschmidtwelzow:
Create valid HTML on Search page

https://gerrit.wikimedia.org/r/145037

jgonera wrote:

This is now fixed, but might require an LD.

Change 145036 merged by jenkins-bot:
Create valid HTML on Search page

https://gerrit.wikimedia.org/r/145036

Change 145037 merged by jenkins-bot:
Create valid HTML on Search page

https://gerrit.wikimedia.org/r/145037

You guys are fast :)