Page MenuHomePhabricator

Cite: If there's no <references /> block on the page for grouped references, maybe show them in some way
Open, MediumPublic

Description

T68860: Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error added a missing reference list for simple references. This functionality was no implemented for references with groups. This should be added to match.

Details

Reference
bz67847

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:37 AM
bzimport added a project: Cite.
bzimport set Reference to bz67847.
bzimport added a subscriber: Unknown Object (MLST).

Maybe grouped references should "fall through", so if you have 3 <ref>s and 4 <ref group="foo">s and a simple <references /> (or now, none) you get 7 items in the reference list, maybe split somehow?

(reverting summary change - looks like something got cut off there James :/)

Sorry, name was meant to express the doubt about the way forward. :-)

(Quoting James Forrester from comment #1)

Maybe grouped references should "fall through", so if you have 3 <ref>s and
4 <ref group="foo">s and a simple <references /> (or now, none) you get 7
items in the reference list, maybe split somehow?

Gadget850, what do you think of this idea?

One way would be to set "MediaWiki:Cite error group refs without references" to <references group=$1 />. But you would have to suppress "MediaWiki:Cite error" and the <strong class="error mw-ext-cite-error">.

"MediaWiki:Cite error group refs without references" has been modified on the test wiki.

Tthat's what I was asking about. We need to decide how to mark reference groups when we add them automatically.

Trying again, because doing a quick check before hitting 'Save Changes' is hard:

That's basically what will end up happening, but we still need to decide how to mark reference *groups* when we add them automatically. Your comment does not really address that.

I just tested this on en.WP with 1.28.0-wmf.15 (rMW878bcfc5d096) using Cite version eadf04d, which has @matmarex's implementation both of display of a references list when no references list is defined, and preview of references, for which the following occurs:

The grouped references are caught in the preview and displayed as a separate list immediately below the non-grouped references list. They are, however, not caught on the normal wikipage. (See permalink to my sandbox.)

That seems odd. :D

I agree that these should probably "fall through" to a root reference definition, or if none present, to the automatically displayed reference list, and then grouped as they are presently in the preview where there is no references list invocation.