Page MenuHomePhabricator

Parsoid shouldn't emit empty text nodes as parts of transclusions
Closed, ResolvedPublic

Description

Screenshot

Transclusion dialog shouldn't render empty text nodes.

Example: try modifying any of the table cell templates at https://nl.wikipedia.org/wiki/Gebruiker:Ad_Huikeshoven/jh?uselang=en&veaction=edit#Prestatietabel

The transclusion dialog will show an empty text node at the end. That node can be removed, which results in no changes in wikitext.

(Re-rendering of these table cell templates is broken, by the way, filed separately as bug 67856.)

(Found when playing with bug 67850.)


Version: unspecified
Severity: normal
URL: https://nl.wikipedia.org/wiki/Gebruiker:Ad_Huikeshoven/jh?uselang=en&veaction=edit#Prestatietabel

Attached:

2014-07-11_16_46_48-Editing_Ad_Huikeshoven_jh_-_Wikipedia_-_Opera.png (730×839 px, 44 KB)

Details

Reference
bz67857

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:38 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz67857.

I think this really should be "Parsoid should not emit zero-length content blocks in transclusions", surely?

Change 147654 had a related patch set uploaded by Subramanya Sastry:
(Bug 67857): Dont push empty "" in table-fixup code.

https://gerrit.wikimedia.org/r/147654

Change 147654 merged by jenkins-bot:
(Bug 67857): Dont push empty "" in table-fixup code.

https://gerrit.wikimedia.org/r/147654

This will go out tomorrow after rt-testing. please reopen if not fixed.