Page MenuHomePhabricator

"Review your changes" dialog should have a save button
Closed, ResolvedPublic1 Story Points

Description

Author: misc2006

Description:
Currently, if you review your changes you need to use the "Return to save form" button and then save. Workflow would be improved if the "Review your changes" view had its own save button. Also note than can cannot close the Review view with the escape key, as it closes the complete dialog instead of just the review view.


Version: unspecified
Severity: enhancement

Details

Reference
bz67868

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz67868.
bzimport created this task.Jul 11 2014, 5:38 PM

Oh, that's a neat idea.

This feels like a bad idea – you'd be letting the user press save without showing them what's in the edit summary…

Perhaps the edit summary input box should stay visible, then? I think that would also be useful. I could both wait for the diff to load *and* type the summary at the same time :)

(In reply to Bartosz Dziewoński from comment #3)

Perhaps the edit summary input box should stay visible, then? I think that
would also be useful. I could both wait for the diff to load *and* type the
summary at the same time :)

So the idea is that when you click "Review your changes", instead of going to a new page of the dialog, the existing one expands to also show all that information? That sounds like a really confusing design…

misc2006 wrote:

@James: see my comment about the escape key: I think the current design is confusing, as the "Review my changes" pages looks a lot like a new dialog but doesn't behave like one.

(In reply to Daniel Naber from comment #5)

@James: see my comment about the escape key: I think the current design is
confusing, as the "Review my changes" pages looks a lot like a new dialog
but doesn't behave like one.

We used to have a booklet on the side of this, but that was more confusing. The escape key always closes the current dialog. What do you propose we do to make it clearer that the current dialog is still the same as the previous page?

misc2006 wrote:

(In reply to James Forrester from comment #6)

We used to have a booklet on the side of this, but that was more confusing.
The escape key always closes the current dialog. What do you propose we do
to make it clearer that the current dialog is still the same as the previous
page?

I'm not sure about mobile and I don't know this old booklet design, but for me there's always enough space to show both the diff and the edit summary at the same time. The edit summary doesn't need four rows anyway I think.

Ltrlg added a comment.Jul 11 2014, 6:50 PM

(In reply to James Forrester from comment #2)

This feels like a bad idea – you'd be letting the user press save without
showing them what's in the edit summary…

There is currently a “summary preview” at the top of this dialog. I prefer to save when I see the parsed summary than when I see the wikitext one, as it is the one that readers will see.

(In reply to Ltrlg from comment #8)

(In reply to James Forrester from comment #2)
> This feels like a bad idea – you'd be letting the user press save without
> showing them what's in the edit summary…

There is currently a “summary preview” at the top of this dialog. I prefer
to save when I see the parsed summary than when I see the wikitext one, as
it is the one that readers will see.

Fair point. OK, let's do this.

Change 226663 had a related patch set uploaded (by Alex Monk):
Add save button to review mode on save dialog

https://gerrit.wikimedia.org/r/226663

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2015, 12:35 AM
Jdforrester-WMF renamed this task from VisualEditor: "Review your changes" dialog should have a save button to "Review your changes" dialog should have a save button.
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 226663 merged by jenkins-bot:
Add save button to review mode on save dialog

https://gerrit.wikimedia.org/r/226663