Page MenuHomePhabricator

Block::newFromTarget gets autoblocks when its documentation says it doesn't
Open, MediumPublic

Description

Block::newFromTarget returns autoblocks when its second parameter is null, even though its doc comment specifically says that it won't. This is dangerous because callers that believe the doc comment could end up leaking autoblocks. I'm not sure whether it's the code or the comment that's "right", though. See comments on I9ea77ae1ac31b44f2bb9767d41192dc0ae492c28


Version: 1.24rc
Severity: major

Details

Reference
bz67938