Hovercards don't show up with $wgUsePathInfo = false
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Se4598
	Jul 15 2014, 3:38 PM

Description

with wgUsePathInfo = false URLs like .../w/index.php?title=Email are always used.
But Hovercards are not shown for which "href.indexOf( '?' ) !== -1" is true for a reason I don't know.

Details

Reference: bz68039

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Popups	master	+5 -11	core: Better article link detection

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T88882 Move Hovercards to OOjs and OOjs UI
Resolved	None	T92555 Turn off 2 month test release of Hovercards on Catalan, and Greek Wikipedias on 2015-06-18
Resolved	• Tnegrin	T88164 Make hovercards default for Catalan and Greek Wikipedias for 2 months starting 2015-04-15
Resolved	• Prtksxna	T70039 Hovercards don't show up with $wgUsePathInfo = false

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:32 AM

• bzimport added a project: Page-Previews.

• bzimport set Reference to bz68039.

• bzimport added a subscriber: Unknown Object (MLST).

Se4598 created this task.Jul 15 2014, 3:38 PM

Change 146477 had a related patch set uploaded by Se4598:
Show popups when wgUsePathInfo=false

https://gerrit.wikimedia.org/r/146477

• Prtksxna triaged this task as Medium priority.Dec 3 2014, 2:54 AM

• Prtksxna updated the task description. (Show Details)

• Prtksxna set Security to None.

• Prtksxna moved this task from Backlog to For Review on the Page-Previews board.Dec 3 2014, 5:44 AM

Change 146477 had a related patch set uploaded (by Prtksxna):
core: Better article link detection

https://gerrit.wikimedia.org/r/146477

Patch-For-Review

• Prtksxna claimed this task.Jan 9 2015, 10:00 AM

yuvipanda removed a subscriber: yuvipanda.Jan 12 2015, 11:54 AM

There is a similar bug on Wikidata spewing JS errors where there are links without href. That patch https://gerrit.wikimedia.org/r/#/c/190209/ would be a minimal fix but the patch linked above would also fix this.

JanZerebecki moved this task from Backlog to Review on the § Wikidata-Sprint-2015-02-03 board.Feb 16 2015, 5:52 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Feb 16 2015, 6:10 PM

• Prtksxna added a parent task: T88164: Make hovercards default for Catalan and Greek Wikipedias for 2 months starting 2015-04-15.Feb 17 2015, 7:01 AM

In T70039#1041903, @JanZerebecki wrote:

There is a similar bug on Wikidata spewing JS errors where there are links without href. That patch https://gerrit.wikimedia.org/r/#/c/190209/ would be a minimal fix but the patch linked above would also fix this.

I'd rather see the actual patch merged rather than a hotfix. I don't want to merge https://gerrit.wikimedia.org/r/#/c/146477/ myself because I changed a lot of things from the original patchset in PS6.

Liuxinyu970226 added a subscriber: Liuxinyu970226.Feb 18 2015, 12:55 PM

Change 146477 merged by jenkins-bot:
core: Better article link detection

https://gerrit.wikimedia.org/r/146477

• Prtksxna mentioned this in rEPOP45cf9c13e742: core: Better article link detection.Feb 18 2015, 3:25 PM

JanZerebecki moved this task from Review to Done on the § Wikidata-Sprint-2015-02-03 board.Feb 18 2015, 4:10 PM

• Prtksxna closed this task as Resolved.Feb 19 2015, 5:26 AM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Feb 19 2015, 8:06 AM

Quiddity moved this task from For Review to Done on the Page-Previews board.Feb 22 2015, 10:29 PM

Se4598 mentioned this in rMEXTc2e460e3e5ad: Updated mediawiki/extensions Project: mediawiki/extensions/Popups….Mar 11 2015, 6:27 AM