Page MenuHomePhabricator

Link in notification points to unexpected destination due to magic linking ("RFC #")
Closed, ResolvedPublic

Description

Author: joshuaissac2000-guard

Description:
Cropped screenshot showing notification dropdown menu with RFC 3 link on hover

On the English Wikipedia, I was thanked by an editor for an edit to a talk page, which had "RFC 3" in its title. Instead of leading to the talk page, the link took me to the RFC 3 page on the IETF website.


Version: unspecified
Severity: normal

Attached:

WikipediaNotificationsRFCBug.png (184×451 px, 6 KB)

Details

Reference
bz68217

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:28 AM
bzimport set Reference to bz68217.
bzimport added a subscriber: Unknown Object (MLST).

Ugh, magic linking is silly :(

EBernhardson subscribed.

sounds like a rather annoying feature of mediawiki, could potentially be fixed by <nowiki> the titles that are not used inside brackets, Alternatively rawParam or plaintextParam on the arguments, but then we have to know the argument wont be used inside a [[ ]] link

This comment was removed by Hex.

Adding that as a blocking task because if the magic linking code is going to be addressed it should be done properly, rather than a hacky workaround in the notifications code.

matmarex claimed this task.
matmarex subscribed.

This problem doesn't occur any more (even when magic links are enabled using $wgEnableMagicLinks['RFC'] = true;). It was probably fixed by rECHO6eea6d93a137: Used parsed section titles for anchors in September 2016.