Page MenuHomePhabricator

Flow: Internal error when following redlink to a non-existent page in Topic namespace
Closed, ResolvedPublic

Description

https://test.wikipedia.org/w/index.php?title=Topic:Foo&action=edit&redlink=1

[42ec2509] /w/index.php?title=Topic:Foo&action=edit&redlink=1 Exception from line 2340 of /usr/local/apache/common-local/php-1.24wmf14/includes/EditPage.php: This content model is not supported: flow-board

Backtrace:

#0 /usr/local/apache/common-local/php-1.24wmf14/includes/EditPage.php(960): EditPage->toEditText(Flow\Content\BoardContent)
#1 /usr/local/apache/common-local/php-1.24wmf14/includes/EditPage.php(536): EditPage->initialiseForm()
#2 /usr/local/apache/common-local/php-1.24wmf14/includes/actions/EditAction.php(49): EditPage->edit()
#3 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(431): EditAction->show()
#4 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(295): MediaWiki->performAction(Article, Title)
#5 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(603): MediaWiki->performRequest()
#6 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(452): MediaWiki->main()
#7 /usr/local/apache/common-local/php-1.24wmf14/index.php(46): MediaWiki->run()
#8 /usr/local/apache/common-local/w/index.php(3): require(string)
#9 {main}


Version: master
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=73443

Details

Reference
bz68258

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:30 AM
bzimport set Reference to bz68258.
bzimport added a subscriber: Unknown Object (MLST).

Put this in the backlog: https://trello.com/c/L7Kokob5

Thanks for the report!

Just for the record, a different error is seen at https://test.wikipedia.org/wiki/Topic:Foo

Error

Invalid value was provided for loading flow content.

Return to Main Page.

[6cf2bd00] /wiki/Topic:Foo Exception from line 162 of /usr/local/apache/common-local/php-1.24wmf14/extensions/Flow/includes/Model/UUID.php: Unknown input to UUID class

Backtrace:

#0 /usr/local/apache/common-local/php-1.24wmf14/extensions/Flow/includes/Actions/Action.php(118): Flow\Model\UUID::create(string)
#1 /usr/local/apache/common-local/php-1.24wmf14/extensions/Flow/includes/Actions/Action.php(70): Flow\Actions\FlowAction->detectWorkflowId(Title, WebRequest)
#2 /usr/local/apache/common-local/php-1.24wmf14/extensions/Flow/includes/Actions/Action.php(32): Flow\Actions\FlowAction->showForAction(string)
#3 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(431): Flow\Actions\FlowAction->show()
#4 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(295): MediaWiki->performAction(Article, Title)
#5 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(603): MediaWiki->performRequest()
#6 /usr/local/apache/common-local/php-1.24wmf14/includes/MediaWiki.php(452): MediaWiki->main()
#7 /usr/local/apache/common-local/php-1.24wmf14/index.php(46): MediaWiki->run()
#8 /usr/local/apache/common-local/w/index.php(3): require(string)
#9 {main}

jbreeze wrote:

Just a note...

I am getting this same error on new pages only. I am using VisualEditor.

When I update the portion of the URL from "&action=edit&redlink=1" to "&veaction=edit&redlink=1" it works fine.

Confirmed on my wiki. Only happens with new pages and when VisualEditor is on. Everything is resolved when VisualEditor is turned off.

Update: VisualEditor isn't the problem. Its the &action=edit portion of the link. If I click on a link that doesn't include &action=edit (even if the page isn't created), such as http://website/w/index.php/User_talk:User, everything works like normal. But if I click a link, such as http://website/w/index.php?title=User_talk:User&action=edit&redlink=1, I get the error described.

(In reply to Justin Breeze from comment #3)

Just a note...

I am getting this same error on new pages only. I am using VisualEditor.

When I update the portion of the URL from "&action=edit&redlink=1" to
"&veaction=edit&redlink=1" it works fine.

The only reason this works is because the &veaction=edit is completely ignored, thus not creating any problem.

Spage renamed this task from Flow: Internal error when visiting a non-existent page in Topic namespace to Flow: Internal error when following redlink to a non-existent page in Topic namespace.Dec 16 2014, 8:11 PM
Spage set Security to None.
Spage claimed this task.

This bug is about the behavior of a wiki link [[Topic:NoSuchUUID]] MW detects the page doesn't exist so turns it into a URL with ?action=edit&redlink=1.

Flow's behavior with such a "redlink" URL is now:

  1. Redirect to plain Topic:NoSuchUUID
  2. With the fix in T75443 , that results in HTTP status 500 and a friendlier "The requested page title was invalid. Pages in the Topic namespace are automatically created by Flow." (flow-error-invalid-topic-uuid msg)

I think this is reasonable behavior, so we can declare this resolved