VisualEditor: Reconsider the "Insert" menu because it doesn't always insert
Open, LowPublic

Description

Use case:

  1. On a page with a heading and some text. Put cursor at start of the paragraph after the heading.
  2. Insert a template (ends up selecting it after finishing insertion)
  3. "Insert" another template.

Expected:

A dialog should appear with the ability to decide which template to insert etc.

Actual:

A dialog appears to edit the selected transclusion that is already on the page.

After being genuinely confused for a minute I realised that the confusion came from the menu label being "Insert". A while back, the "Template" button was separate on the toolbar (or under "More" or "Tools" whatever it was). Back then, like still the case with Links and Text Style, it was more natural to assume it will edit and not create a template when a template is selected already because the button would be rendered in an "active" (pressed-down) state (like for links and text style). However, the menu was then relabelled to "Insert" and the items in the "Insert" menu do not have an "active" state to help correlate with the currently selected item on the page.

Perhaps we should bring back the "active" state for the Insert menu items, for consistency with other buttons on the toolbar.

Or make it actually insert a new one at/before the current cursor position, which would mean that to edit a transclusion users then need to use the context menu instead.

Details

Reference
bz68494
bzimport raised the priority of this task from to Low.
bzimport set Reference to bz68494.
Krinkle created this task.Jul 24 2014, 2:20 AM
matmarex renamed this task from VisualEditor: Reconsider the "insert" menu because it doesn't to VisualEditor: Reconsider the "Insert" menu because it doesn't always insert.Sat, Dec 30, 2:59 AM
matmarex updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)Mon, Jan 8, 5:48 PM