Page MenuHomePhabricator

Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]]
Closed, ResolvedPublic

Details

Reference
bz68521

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:30 AM
bzimport added a project: GlobalCssJs.
bzimport set Reference to bz68521.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Jul 24 2014, 6:26 PM

OutputPage::makeResourceLoaderLink should handle this properly, I'm looking into why it isn't.

https://github.com/wikimedia/mediawiki-core/blob/master/includes/OutputPage.php#L2726 isn't checking TYPE_COMBINED, which our global user module is using.

Change 149185 had a related patch set uploaded by Legoktm:
Check whether TYPE_COMBINED modules are allowed to be included in the page

https://gerrit.wikimedia.org/r/149185

Change 150442 had a related patch set uploaded by Legoktm:
Use OutputPage::addModuleStyles/Scripts to add modules

https://gerrit.wikimedia.org/r/150442

Change 150442 merged by jenkins-bot:
Use OutputPage::addModuleStyles/Scripts to add modules

https://gerrit.wikimedia.org/r/150442

My global CSS is loaded on Special Preferences (both on Meta and other wikis).

I can't reproduce right now, but moving to the security component just in case.

Okay, I can confirm my global CSS is being loaded, but not JS. Investigating...

(In reply to Kunal Mehta (Legoktm) from comment #10)

Okay, I can confirm my global CSS is being loaded, but not JS.
Investigating...

See bug 70672.

This is fixed with the patch applied in bug 70672.