Page MenuHomePhabricator

Document how much memory Echo needs
Open, LowPublic

Description

php5 phpunit.php

When doing http://paste.debian.net/111811/ (minus roles globalcssjs math mathsearch cirrussearch disabled for other bugs), phpunit incurs in this:

Call Stack:

 0.0006     252912   1. {main}() /srv/vagrant/mediawiki/tests/phpunit/phpunit.php:0
 1.6730   25034984   2. MediaWikiPHPUnitCommand::main() /srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160
 1.6731   25047464   3. PHPUnit_TextUI_Command->run() /srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
54.0682  196208536   4. PHPUnit_TextUI_TestRunner->doRun() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:176
54.0900  196531104   5. PHPUnit_Framework_TestSuite->run() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/TextUI/TestRunner.php:350

3064.1041 1021505888 6. PHPUnit_Framework_TestSuite->run() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
3064.1045 1021507392 7. PHPUnit_Framework_TestSuite->run() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
4446.2597 1133579552 8. PHPUnit_Framework_TestSuite->run() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
4824.9264 1135002824 9. PHPUnit_Framework_TestSuite->runTest() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:749
4824.9264 1135002824 10. MediaWikiTestCase->run() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:779
4824.9265 1135003000 11. PHPUnit_Framework_TestCase->run() /srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
4824.9265 1135003000 12. PHPUnit_Framework_TestResult->run() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:783
4824.9360 1135003944 13. PHPUnit_Framework_TestCase->runBare() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestResult.php:648
4825.3453 1135355544 14. PHPUnit_Framework_TestCase->runTest() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:838
4825.3453 1135356344 15. ReflectionMethod->invokeArgs() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:988
4825.3453 1135356544 16. ApiFlickrBlacklistTest->testBlacklistMatchWithMultipleItems() /srv/vagrant/mediawiki/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:988
4825.4426 1135462328 17. ApiTestCase->editPage() /srv/vagrant/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:76
4825.4427 1135463184 18. WikiPage->doEditContent() /srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiTestCase.php:56
4826.0388 1135580848 19. ContentHandler::runLegacyHooks() /srv/vagrant/mediawiki/includes/page/WikiPage.php:2046
4826.0388 1135583056 20. wfRunHooks() /srv/vagrant/mediawiki/includes/content/ContentHandler.php:1154
4826.0388 1135583104 21. Hooks::run() /srv/vagrant/mediawiki/includes/GlobalFunctions.php:4031
4826.0389 1135585768 22. call_user_func_array() /srv/vagrant/mediawiki/includes/Hooks.php:206
4826.0389 1135587152 23. EchoHooks::onArticleSaved() /srv/vagrant/mediawiki/includes/Hooks.php:206
4826.0389 1135587152 24. EchoDiscussionParser::generateEventsForRevision() /srv/vagrant/mediawiki/extensions/Echo/Hooks.php:463
4826.0389 1135587152 25. EchoDiscussionParser::getChangeInterpretationForRevision() /srv/vagrant/mediawiki/extensions/Echo/includes/DiscussionParser.php:17
4826.0450 1135597856 26. EchoDiscussionParser::getMachineReadableDiff() /srv/vagrant/mediawiki/extensions/Echo/includes/DiscussionParser.php:290
4826.0450 1135597856 27. EchoDiffParser->getChangeSet() /srv/vagrant/mediawiki/extensions/Echo/includes/DiscussionParser.php:609
4826.0451 1135598120 28. wfDiff() /srv/vagrant/mediawiki/extensions/Echo/includes/DiffParser.php:93

In that moment the labs instance in question had only few MB free memory out of 2 GB because 700 MB (and 1000 virtual) were taken by puppet... No idea if this should be considered a bug or we should just advise people to have more RAM.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz68632

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:38 AM
bzimport added a project: Notifications.
bzimport set Reference to bz68632.
bzimport added a subscriber: Unknown Object (MLST).

Seems related to vagrant setup, not bug 67216 which is about having extensions pass tests together.

I don't think Echo can do much about this since we're just using wfDiff. It would be nice if we could benchmark how much memory Echo needs...

It's not included in the bug, but if you check the file, the root error is:

Warning: popen(/usr/bin/diff -u -w '/tmp/merge-old-zGR15f' '/tmp/merge-your-fiN6yG',r): Cannot allocate memory in /srv/vagrant/mediawiki/includes/GlobalFunctions.php on line 3216