Page MenuHomePhabricator

Factor interaction logic out of MergeItems API module, for re-use in SpecialMergeItems
Closed, ResolvedPublic

Description

MergeItems is the most complex API module we have and it needs quite some refactoring/splitting up. What and how exactly should be discussed and turn into small actionable items.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=5 s=2014-08-26

Details

Reference
bz68730

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:27 AM
bzimport set Reference to bz68730.
bzimport added a subscriber: Unknown Object (MLST).

(updated the summary, changing scope slightly)

MergeItems is not that complex compared to EditEntity or even GetEntities. However, before we add more functionality (like automatically creating redirects), we want to factor the interaction logic (aka business logic) out of the API module, so it can be reused by the correspinding special page.

daniel added a comment.Aug 4 2014, 2:22 PM

Relevant patch https://gerrit.wikimedia.org/r/#/c/151145/

Should be sufficient, I made a new ticket for refactoring SpecialMergeItem (bug 69106).

Change 151145 merged by jenkins-bot:
Introducing MergeItemsInteractor

https://gerrit.wikimedia.org/r/151145

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 29 2015, 4:51 PM