I have added a job template in Jenkins Job Builder which let us check for tabs in puppet manifest. Have to refactor the template so it can be applied on other repositories such as operations/dns.git

https://gerrit.wikimedia.org/r/#/c/148437/

not sure why the bot did not add the gerrit link yet

Change 150067 had a related patch set uploaded by Dzahn:
mediawiki.org - retab

https://gerrit.wikimedia.org/r/150067

Change 150068 had a related patch set uploaded by Dzahn:
0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa - retab

https://gerrit.wikimedia.org/r/150068

Change 150068 merged by BBlack:
0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa - retab

https://gerrit.wikimedia.org/r/150068

Change 150095 had a related patch set uploaded by Dzahn:
wmnet - retab only

https://gerrit.wikimedia.org/r/150095

Change 150095 merged by BBlack:
wmnet - retab only

https://gerrit.wikimedia.org/r/150095

https://gerrit.wikimedia.org/r/143208
https://gerrit.wikimedia.org/r/143212
https://gerrit.wikimedia.org/r/148437
https://gerrit.wikimedia.org/r/150067
https://gerrit.wikimedia.org/r/150068
https://gerrit.wikimedia.org/r/150069
https://gerrit.wikimedia.org/r/150070
https://gerrit.wikimedia.org/r/150071
https://gerrit.wikimedia.org/r/150072
https://gerrit.wikimedia.org/r/150093
https://gerrit.wikimedia.org/r/150094
https://gerrit.wikimedia.org/r/150095
https://gerrit.wikimedia.org/r/150096
https://gerrit.wikimedia.org/r/150099
https://gerrit.wikimedia.org/r/150103
https://gerrit.wikimedia.org/r/150105
https://gerrit.wikimedia.org/r/150101
https://gerrit.wikimedia.org/r/150107
https://gerrit.wikimedia.org/r/150109
https://gerrit.wikimedia.org/r/150108

• to go: --

https://gerrit.wikimedia.org/r/150130
https://gerrit.wikimedia.org/r/150127
https://gerrit.wikimedia.org/r/150129
https://gerrit.wikimedia.org/r/150132
https://gerrit.wikimedia.org/r/150133
https://gerrit.wikimedia.org/r/150134
https://gerrit.wikimedia.org/r/150135
https://gerrit.wikimedia.org/r/150136

*boom*

all merged, all clean, plus this one that fixes the templates:

https://gerrit.wikimedia.org/r/#/c/150397/

and done :)

~/wmf/dns/templates$ grep -l -P '\t' *.*
~/wmf/dns/templates$

bah, besides config-geo one directory up :)

..and langlist template:

https://gerrit.wikimedia.org/r/#/c/150397/

..and config-geo

https://gerrit.wikimedia.org/r/#/c/150406/

resolved :) thanks bblack for reviews

eh, reopening for hashar to make the jenkins change, wasn't sure if that should have been a separate bug now

Change 151064 had a related patch set uploaded by Hashar:
Refactor tabs detector to job template

https://gerrit.wikimedia.org/r/151064

Change 151064 merged by jenkins-bot:
Refactor tabs detector to job template

https://gerrit.wikimedia.org/r/151064

The tab check for operations/puppet.git only lint .pp files and only look for tabs at the beginning of the line.

I believe operations/dns.git would want to prevent all tabs, regardless of their position.

We would need two different templates. Ie -tabs and -leadingtabs.

This is now completed. Another bug tracked the addition of the Jenkins job.