Page MenuHomePhabricator

DatabaseUpdater::modifyField() does insertUpdateRow() before applyPatch()
Closed, ResolvedPublic

Description

DatabaseUpdater::modifyField() does insertUpdateRow() before applyPatch(). As a result, if there's a database error modifying the field, the updatelog table will have already been updated, so that if update.php is run again, it will skip making another attempt to modify that field.

Details

Reference
bz68786

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:31 AM
bzimport added a project: Wikimedia-Rdbms.
bzimport set Reference to bz68786.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle updated the task description. (Show Details)
Krinkle edited subscribers, added: EddieGP; removed: wikibugs-l-list.

Change 352216 had a related patch set uploaded (by EddieGP; owner: EddieGP):
[mediawiki/core@master] Add DatabaseUpdater::modifyTable

https://gerrit.wikimedia.org/r/352216

Change 352216 merged by jenkins-bot:
[mediawiki/core@master] Add DatabaseUpdater::modifyTable

https://gerrit.wikimedia.org/r/352216

Krinkle closed this task as Resolved.May 7 2017, 8:07 PM
Krinkle assigned this task to EddieGP.
Krinkle removed a project: Patch-For-Review.