DatabaseUpdater::modifyField() does insertUpdateRow() before applyPatch(). As a result, if there's a database error modifying the field, the updatelog table will have already been updated, so that if update.php is run again, it will skip making another attempt to modify that field.
Description
Description
Details
Details
- Reference
- bz68786
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add DatabaseUpdater::modifyTable | mediawiki/core | master | +40 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | EddieGP | T56888 Fresh MW lists "-1 recent contributors" / Overhaul site_stats table | |||
| Resolved | EddieGP | T70786 DatabaseUpdater::modifyField() does insertUpdateRow() before applyPatch() |
Event Timeline
Comment Actions
Change 352216 had a related patch set uploaded (by EddieGP; owner: EddieGP):
[mediawiki/core@master] Add DatabaseUpdater::modifyTable
Comment Actions
Change 352216 merged by jenkins-bot:
[mediawiki/core@master] Add DatabaseUpdater::modifyTable