Our API modules depend on subclassing for common operations. This makes it hard to mix and match, and makes it virtually impossible to mock all services used by a given API module (see T57516).
To fix this, we should create helper classes for specific aspects of API operations (e.g. finding entities, saving entities, etc), and use them in the concrete modules via composition.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | None | T70917 Refactor Wikibase API tests to avoid database access | |||
| Declined | None | T71001 [Task] Replace base classes ApiWikibase, ModifyEntity, ModifyClaim, etc. with composable objects. |
Change 222928 had a related patch set (by Addshore) published:
Get rid of ApiWikibase!!!!
Change 232045 had a related patch set uploaded (by Addshore):
Push isWriteMode and needsToken methods down the API
Change 232052 had a related patch set uploaded (by Addshore):
WIP Kill ModifyClaim base class
Change 232045 merged by jenkins-bot:
Push isWriteMode and needsToken methods down the API
Change 232052 abandoned by Addshore:
WIP Kill ModifyClaim base class
Reason:
It will be easier to start a fresh patch to achieve this in the future...
Change 266798 had a related patch set uploaded (by Addshore):
Kill ModifyClaim base class
We will progressively move away from the old Action API toward a REST API which will be constructed differently.