Page MenuHomePhabricator

Hardcoded path to Popups settings icon
Closed, ResolvedPublic

Description

The settings icon introduced in I374805e is hardcoded to reside at '/w/extensions/Popups/resources/gear_gray.svg' which can’t be right, it needs to be configuration-dependent. For instance, the code does not even work on the WMF cluster, where it leads to 404, check on the testwiki: https://test.wikipedia.org/w/extensions/Popups/resources/gear_gray.svg

Moreover, I don’t think using SVG files directly like this is acceptable, as older browsers do not support SVG. Cf. https://www.mediawiki.org/wiki/Manual:Assets


Version: unspecified
Severity: normal

Details

Reference
bz69022

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:29 AM
bzimport added a project: Page-Previews.
bzimport set Reference to bz69022.
bzimport added a subscriber: Unknown Object (MLST).
Mormegil created this task.Aug 1 2014, 7:45 PM

A fix for both the path and SVG fallback is to put class mwe-popups-settings-icon on a span, and then use the background-image-svg( 'resources/gear_gray.svg', 'resources/gear_gray.png' ) LESS mixin.

Add a comment somewhere saying where the icon came from, and a @TODO use WikiFont glyph.

With I3cf15bc4f9c9f1273b896d0e256f5821f15222fb it now correctly uses wgExtensionAssetsPath

Change 155067 had a related patch set uploaded by Prtksxna:
article: Fix settings icon

https://gerrit.wikimedia.org/r/155067

Change 155067 merged by jenkins-bot:
article: Fix settings icon

https://gerrit.wikimedia.org/r/155067

Prtksxna moved this task from Backlog to Archive on the Page-Previews board.Dec 3 2014, 3:15 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 5:56 PM