Page MenuHomePhabricator

Special:Block: Use Config instead of globals
Closed, ResolvedPublic

Description

There are a lot of static functions in SpecialBlock so that the API can also re-use the same code which makes this difficult. Might need some more refactoring...?

Details

Reference
bz69087

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:33 AM
bzimport set Reference to bz69087.
bzimport added a subscriber: Unknown Object (MLST).

Static function SpecialBlock::processForm has a context source as param, which can provide a config object, but all the other functions needs another way to do.

Change 153266 had a related patch set uploaded by Florianschmidtwelzow:
WIP: Special:Block: Use config object instead of globals

https://gerrit.wikimedia.org/r/153266

Change 153266 abandoned by Florianschmidtwelzow:
WIP: Special:Block: Use config object instead of globals

Reason:
maybe first think about and then do something :/

https://gerrit.wikimedia.org/r/153266

Tchanders claimed this task.
Tchanders added a subscriber: Tchanders.

SpecialBlock has been through a lot of treatment since this was opened, and is no longer accessing global variables.