Page MenuHomePhabricator

LivePreview doesn't allow interaction with page content outside of #wikiPreview (it is not passed to mw.hook)
Open, NormalPublic

Description

Currently, LivePreview only passes the $wikiPreview to the hook
https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki.action/mediawiki.action.edit.preview.js#L101
but the script changes the page content in many other places:
https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki.action/mediawiki.action.edit.preview.js#L31-L43
The new content for these parts should also be made available to the user, by passing them to the hook (as VisualEditor does, for example
https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/ccdc215a9882d6bb3e079ca822f64c9089c0d363/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js#L1574
).

This would allow scripts like
https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-featured-articles-links.js&oldid=619815637
to update the modifications of the language links after the user makes some changes and use the live preview (in the example, the "badges" for featured/good articles in other languages).

Also, this is likely what UniversalLanguageSelector needs in order to fix bug T53029.


Version: unspecified
Severity: normal

Details

Reference
bz69108

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:34 AM
bzimport added a project: MediaWiki-JavaScript.
bzimport set Reference to bz69108.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Aug 4 2014, 2:49 PM
TheDJ updated the task description. (Show Details)Mar 16 2015, 4:39 PM
TheDJ set Security to None.
TheDJ removed a subscriber: Unknown Object (MLST).
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2015, 7:55 PM