http://en.wikipedia.beta.wmflabs.org/w/index.php?diff=118689&oldid=101159
This took a perfectly normal link like:
[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]
and turned it into something completely broken (single brackets instead of double, and space instead of pipe):
[mw:User talk:Whatamidoing (WMF) on Mediawiki]
Version: unspecified
Severity: major
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/services/parsoid | master | +9 -18 | Auto-detect interwiki links without needing data-parsoid info |
Also, I didn't touch any of those links. I added a space in one paragraph so I could look at the Save dialog, and it broke all of these interwiki links on the entire page.
I cannot reproduce this on http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Whatamidoing_(WMF)/Sandbox&oldid=101159 when I try to edit again.
However, I can reproduce it locally on the commandline if a data-parsoid flag is removed.
[subbu@earth lib] echo '[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]' | node parse | sed 's/"isIW":true,//g;' | node parse --html2wt
[mw:User talk:Whatamidoing (WMF) on Mediawiki]
So, it is unclear how this might have happened. Clearly, the original and modified HTML differed on all these links for them to get re-serialized and because of the missing attribute in data-parsoid, the serialization breaks.
Could this have been a transient VE bug that clobbered data-parsoid somehow?
Unrelated to the bug report: we'll probably make our link handling code more robust since we can recover most information without the flag being present. This is part of the general link handling cleanup that needs to happen in Parsoid.
Note that I can still reproduce this on the command line:
vagrant@mediawiki-vagrant:/vagrant/srv/parsoid/src/bin$ echo '[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]' | node parse | sed 's/"isIW":true,//g;' | node parse --html2wt [mw:User talk:Whatamidoing (WMF) on Mediawiki]
Change 292078 had a related patch set uploaded (by Subramanya Sastry):
WIP: Auto-detect interwiki links without needing data-parsoid info
Change 292078 merged by jenkins-bot:
Auto-detect interwiki links without needing data-parsoid info
On latest master now:
[subbu@earth parsoid] echo '[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]' | bin/parse.js | sed 's/"isIW":true,//g;' | bin/parse.js --html2wt [[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]
I retried James example the current Parsoid and it seems to work properly. Is there another failing case I can look at?
... sbailey$ echo '[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]' | node bin/parse > text
... sbailey$ node bin/parse --inputfile text --html2wt
[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]
@Sbailey: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task?
If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)
This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!
For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)