Page MenuHomePhabricator

Flow: no-JS "cancel" buttons also submit the form
Closed, ResolvedPublic


We're using <button>s for Cancel. There's some javascript that will properly destroy the forms when that button is clicked, but without JS, that button will also submit the form. That's probably not what you'd expect when you hit cancel.

We probably just want to hide those buttons if users run Flow without JS, like:

.client-nojs button[data-role=cancel] {
    display: none;

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:41 AM
bzimport set Reference to bz69221.
bzimport added a subscriber: Unknown Object (MLST).

Change 152241 had a related patch set uploaded by Matthias Mullie:
(bug 69221) Hide cancel <button>s for no-js

Change 152241 merged by jenkins-bot:
(bug 69221) Hide cancel <button>s for no-js

Patch was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.