Page MenuHomePhabricator
Create Task
Maniphest T71230

Transclusion dialog's "Add more information" button responds to right-click but should not
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Add more information element

At the bottom of the Cite web UI is an element "Add more information".

In Chrome, a right-click on "Add more information" correctly has no effect.

But in Firefox, a right-click "Add more information" has the same effect as a left-click, triggering the action.

Version: unspecified
Severity: minor

Attached:

Screen_Shot_2014-08-07_at_12.29.08_PM.png (502×628 px, 34 KB)

Details

Reference
bz69230

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:42 AM
• bzimport added projects: VisualEditor, Browser-test-bug.
• bzimport set Reference to bz69230.
• Cmcmahon created this task.Aug 7 2014, 11:29 AM
Krenair renamed this task from Firefox: Cite/Add more information responds to right-click but should not to Firefox: Transclusion dialog's "Add more information" button responds to right-click but should not.Jan 22 2015, 12:38 AM
Krenair added a project: Browser-Support-Firefox.
Krenair set Security to None.
Krenair subscribed.Jan 22 2015, 12:46 AM

Looks like this is because of the focus event handler on $more in MWParameterPage. Firefox fires focus on right click here, Chrome does not

Jdforrester-WMF renamed this task from Firefox: Transclusion dialog's "Add more information" button responds to right-click but should not to Transclusion dialog's "Add more information" button responds to right-click but should not.Apr 17 2015, 8:10 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Templates; removed Browser-Support-Firefox, Browser-test-bug.

Not Firefox specific any more.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Apr 17 2015, 11:44 PM
matmarex subscribed.May 9 2016, 9:22 PM

I can't reproduce this today.

The <div class="ve-ui-mwParameterPage-more"> has a 'focus' handler, but it can't actually be focussed, as far as I can tell.

Ryasmeen closed this task as Resolved.May 10 2016, 1:04 PM
matmarex added a comment.May 10 2016, 5:28 PM
In T71230#2278157, @matmarex wrote:

The <div class="ve-ui-mwParameterPage-more"> has a 'focus' handler, but it can't actually be focussed, as far as I can tell.

https://gerrit.wikimedia.org/r/287994

Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.May 16 2016, 8:27 AM
Jdforrester-WMF set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL