Page MenuHomePhabricator

$feedTitle = "$wgSitename - {$title} [$wgLanguageCode]" repeated in multiple places
Open, LowPublic

Description

In SpecialNewPages, ChangesListSpecialPage, ApiFeedWatchlist, and now ChangesList::getFeedObject.

Probably should be one common function. Also I think there's other duplicated code related to that...


Version: 1.24rc
Severity: minor

Details

Reference
bz69258
Related Changes in Gerrit:

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:28 AM
bzimport set Reference to bz69258.
bzimport added a subscriber: Unknown Object (MLST).
xSavitar claimed this task.
xSavitar subscribed.

I've searched around and do not see any occurrences of this piece of code! Please reopen if I'm wrong!

Legoktm removed xSavitar as the assignee of this task.

Some of the instances now use Config instead of globals, but it's still duplicated:

https://codesearch.wmflabs.org/core/?q=%5C%24feedTitle&i=nope&files=&repos=

Change #1078038 had a related patch set uploaded (by Riccardo_c; author: Riccardo_c):

[mediawiki/core@master] Feed: Add method to format the feed title

https://gerrit.wikimedia.org/r/1078038

Change #1078038 abandoned by Riccardo_c:

[mediawiki/core@master] Feed: Add method to format the feed title

https://gerrit.wikimedia.org/r/1078038

Pppery added a subscriber: RiccardoCampo.