Page MenuHomePhabricator

Special:PageMigration and Special:PagePreparation don't react to enter
Closed, ResolvedPublic

Description

  1. Fill the fields
  2. Press enter

I. Expected: the action corresponding to the main (and only) button is triggered.
II. Observed: nothing happens, I'm forced to click.


Version: master
Severity: minor

Details

Reference
bz69271
Related Changes in Gerrit:

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:29 AM
bzimport set Reference to bz69271.

pr4tiklahoti wrote:

Yes, this is because the type attribute of those buttons is set to 'button' right now and not 'submit'. I don't want to change it to submit as it would submit the form and follow the default behaviour. Perhaps a workaround like this could be useful:

http://stackoverflow.com/a/155263

Please let me know if that is okay.

If that is not ok (I have no idea), a text explaining that one has no click would be helpful.

It seems that the observed behaviour has changed from nothing happening to a page reload.

Change #1258315 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Translate@master] PagePreparation cleanup/modernization

https://gerrit.wikimedia.org/r/1258315

The PageMigration case was fixed already as part of T71273. Above patch fixes the PagePreparation case.

Change #1258315 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PagePreparation cleanup/modernization

https://gerrit.wikimedia.org/r/1258315