Page MenuHomePhabricator

Echo qunit tests break MobileFrontend tests
Closed, ResolvedPublic

Description

Chrome error console

The qunit tests, introduced in Echo, actually breaks qunit tests of MobileFrontend (if Echo is installed). Error message from console:
Uncaught Error: Unknown dependency: ext.echo.overlay (which loads only by desktop)

(see picture for more details)

Caused by: https://gerrit.wikimedia.org/r/#/c/151976/
(works with 0dc45e6c4ac1b8b918774376169f77214b0e11a3 [1], works not with 8d12ef9a8032854e5ecbef46cf4e2c0262285266 [2])

[1] https://github.com/wikimedia/mediawiki-extensions-Echo/commit/0dc45e6c4ac1b8b918774376169f77214b0e11a3#diff-d41d8cd98f00b204e9800998ecf8427e
[2] https://github.com/wikimedia/mediawiki-extensions-Echo/commit/8d12ef9a8032854e5ecbef46cf4e2c0262285266


Version: master
Severity: major

Attached:

Details

Reference
bz69316

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:33 AM
bzimport added a project: Notifications.
bzimport set Reference to bz69316.
bzimport added a subscriber: Unknown Object (MLST).
Florian created this task.Aug 9 2014, 12:01 AM

Change 152999 had a related patch set uploaded by Jdlrobson:
Stop breaking MobileFrontend QUnit tests

https://gerrit.wikimedia.org/r/152999

Change 153000 had a related patch set uploaded by Florianschmidtwelzow:
Remove qunit tests from mobile

https://gerrit.wikimedia.org/r/153000

Change 153000 merged by jenkins-bot:
Remove qunit tests from mobile

https://gerrit.wikimedia.org/r/153000

Change 152999 abandoned by Jdlrobson:
Stop breaking MobileFrontend QUnit tests

Reason:
Florian's way was better.

https://gerrit.wikimedia.org/r/152999

Change https://gerrit.wikimedia.org/r/#/c/153000/1 merged, tested and ok -> Resolved