Page MenuHomePhabricator

VIPS scaled thumbnails don't have a comment with a link to the file description page
Closed, DeclinedPublic

Description

As part of T30135: Review and deploy VipsScaler extension we added the option to set the comment of a thumbnail with the file descriptionpage url that it came from, as we did for the imagemagick scalar. It seems however that the option was never actually enabled in the configuration for the sites, and that we have been generating thumbnails without 'backtrack' urls ever since then...

That's not really what was intended.

This relates to the "setcomment" options of wgVipsOptions

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:34 AM
bzimport set Reference to bz69336.
bzimport added a subscriber: Unknown Object (MLST).

Hmm. Is exiv2 on the servers? I think the option depends on that.

Dereckson added a project: SRE.
Dereckson subscribed.

@Bawolff So next step is to install pyexiv2 on mediawiki::packages::multimedia?

[ Taking this bug, as I can sheperd it, but I'll mainly rely on @Bawolff and @TheDJ  support for their extension knowledge to do this. ]

Change 309505 had a related patch set uploaded (by Dereckson):
Install exiv2 to mediawiki::packages::multimedia

https://gerrit.wikimedia.org/r/309505

So the question is to know if we want to do this with exiv2, or if we want to update the VIPS extension code to support exiftool, already installed on multimedia servers.

@TheDJ Do you have an opinion about this?

@Dereckson right. I have no opinion on this. My ticket was only an observation about functionality that we lost compared to the pre-vips stages, and I have no specific preferences in how it gets resolved.

Change 309505 abandoned by Dereckson:
Install exiv2 to mediawiki::packages::multimedia

Reason:
No preference for this solution

https://gerrit.wikimedia.org/r/309505

To summarize, it was offered to solve right now the issue installing the missing software. This solution doesn't have any enthusiasm from the current extension maintainers.

An alternative solution offered is to improve the extension code to use exiftool, already deployed on the scalers, to perform this task.

fgiunchedi subscribed.

Removing SRE as there isn't anything to do ATM, though Thumbor might be a good place for a wishlist in this case

It seems like thumbor has taken over thumbnailing, and it never sets the old jpg comment at all.

So i guess this could be closed?

I also don't know why we have VIPS installed at all in a post-thumbor world.

Closing, as i don't think there's much point anymore when we don't use vips to scale things.

I also don't know why we have VIPS installed at all in a post-thumbor world.

See T290759