Maniphest T71382

[[Special:Search]] shows "Results 1 - 2 of 2" when there is only one result
Closed, ResolvedPublic
Actions

Description

When I search for "nomedoartigo" on Portuguese Wikipedia, MediaWiki returns

Result 1 of 1

but does not show any pages in the list

In the original bug report, it returned the message

Results 1 - 2 of 2 for "nomedoartigo"

but only listed one result (pt:Paulo Lima de Brito, now deleted)

Details

Reference: bz69382

	Subject	Repo	Branch	Lines +/-
	Dont override SearchResultSet::numRows()	mediawiki/extensions/CirrusSearch	master	+0 -14

Customize query in gerrit

Related Objects

Mentioned In: T202258: SpecialSearch displays "Results 1-21" instead of "1-20"

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:37 AM

• bzimport added a project: MediaWiki-Search.

• bzimport set Reference to bz69382.

• bzimport added a subscriber: Unknown Object (MLST).

He7d3r created this task.Aug 11 2014, 12:07 AM

Gah, I don't think it's a Cirrus bug, I think I'm still fighting an off-by-one bug in core's Special:Search. This has been frustrating :\

Indeed. Lucene has the same problem:
https://pt.wikipedia.org/w/index.php?title=Especial:Pesquisar&search=%22nomedoartigo%22&fulltext=Busca&ns0=1&ns102=1&profile=advanced&srbackend=LuceneSearch&uselang=en

• demon unsubscribed.Aug 19 2015, 4:00 PM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptAug 19 2015, 4:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Deskana lowered the priority of this task from Medium to Lowest.Dec 23 2015, 5:19 AM

• Deskana moved this task from Needs triage to Search on the Discovery-ARCHIVED board.

He7d3r updated the task description. (Show Details)Dec 23 2015, 1:35 PM

He7d3r set Security to None.

Anyone has a test case that still works?

Restricted Application added a project: Discovery-Search. · View Herald TranscriptAug 20 2018, 8:54 AM

Aklapper mentioned this in T202258: SpecialSearch displays "Results 1-21" instead of "1-20".Aug 20 2018, 8:54 AM

dcausse merged a task: T202258: SpecialSearch displays "Results 1-21" instead of "1-20".Aug 20 2018, 9:00 AM

dcausse subscribed.

In T71382#4513936, @Aklapper wrote:

Anyone has a test case that still works?

https://pt.wikipedia.org/w/index.php?search=nome&title=Especial:Pesquisar&profile=advanced&fulltext=1&advancedSearch-current=%7B%22namespaces%22%3A%5B0%5D%7D&ns0=1&searchToken=b9wvwtygk3ktp36yhjrkzsdq

GoEThe unsubscribed.Aug 21 2018, 12:17 PM

In T71382#4513936, @Aklapper wrote:
Anyone has a test case that still works?

https://pt.wikipedia.org/w/index.php?search=nome&title=Especial:Pesquisar&profile=advanced&fulltext=1&advancedSearch-current=%7B%22namespaces%22%3A%5B0%5D%7D&ns0=1&searchToken=b9wvwtygk3ktp36yhjrkzsdq

We'll take a look at this.

EBernhardson claimed this task.Sep 5 2018, 5:52 PM

EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

Change 458316 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Dont override SearchResultSet::numRows()

https://gerrit.wikimedia.org/r/458316

gerritbot added a project: Patch-For-Review.Sep 5 2018, 10:29 PM

EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Sep 5 2018, 10:30 PM

Change 458316 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Dont override SearchResultSet::numRows()

https://gerrit.wikimedia.org/r/458316

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 6 2018, 10:00 AM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 6 2018, 4:08 PM

debt closed this task as Resolved.Sep 13 2018, 9:13 PM