Page MenuHomePhabricator

PHP Warning: Invalid argument
Closed, ResolvedPublic

Description

When using CirrusSearch (Master) we get the following with mw1.23.2. I know we should use CirrusSearch 1.23 but I wanted to try the newest changes and also Elasticserach 1.3.1.
While running "php forceSearchIndex.php" we get this message about a 1000 times, but on the good side: search is WORKING :-)

PHP Warning: Invalid argument supplied for foreach() in .../CirrusSearch/includes/BuildDocument/PageTextBuilder.php on line 129


Version: master
Severity: minor
OS: Linux

Details

Reference
bz69459

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:42 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz69459.

CirrusSearch master generally depends on MW master and probably won't work all that well with the 1.23.x release branch. In this case, we're relying on gerrit change 127238 from core.

I'll commit a fix in a moment that protect Cirrus master here a bit more and should make things a tad more compatible.

Change 156712 had a related patch set uploaded by Chad:
Protect against older versions of HtmlFormatter

https://gerrit.wikimedia.org/r/156712

Change 156712 merged by jenkins-bot:
Protect against older versions of HtmlFormatter

https://gerrit.wikimedia.org/r/156712

Thank you Chad an Nik, as always!