Embeddable HTML for file reuse is incorrect for files at the Commons
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Lupo
	Aug 13 2014, 10:03 PM

Description

https://commons.wikimedia.org/wiki/Template:Cc-by-sa-layout and possibly other license templates contain extra whitespace and in particular line breaks in the HTML-based license metadata.

The "Use this file" function includes these linebreaks in the generated embedding HTML, which then doesn't work correctly (the license isn't linked).

The HTML generated is

Note the linebreaks in the title and href attributes of the license link.

While this could be fixed in the templates, I think it'd be better to fix this in the MediaViewer by doing a trim() of the extracted metadata.

Version: unspecified
Severity: normal

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM

• bzimport set Reference to bz69497.

• bzimport added a subscriber: Unknown Object (MLST).

BTW, it'd be very nice if the MediaViewer would just generate the links back to the file as

instead of

(In reply to Lupo from comment #1)

BTW, it'd be very nice if the MediaViewer would just generate the links back
to the file

That is covered in bug 62266 instead.

(In reply to Andre Klapper from comment #3)

That is covered in bug 62266 instead.

I don't understand. Bug 62266 is about browser history, not about the backlink generated into embeddable HTML.

Does MediaViewer use the extmetadata API? If so, this bug should probably moved to the MediaWiki API component:

returns:

"UsageTerms": {

"value": "Creative Commons Attribution-Share Alike 3.0\n",
"source": "commons-desc-page",
"hidden": ""

},
"LicenseUrl": {

"value": "http://creativecommons.org/licenses/by-sa/3.0\n",
"source": "commons-desc-page",
"hidden": ""

Again, note the line breaks in the values.