Page MenuHomePhabricator
Create Task
Maniphest T71633

Flow: "Thanked" item doesn't appear disabled after Thanking
Closed, ResolvedPublic
Actions

Description

After thanking someone, the Thank post action link changes to "Thanked" and goes dead (good), but appears with the same #666 color as the other post actions "Reply · Edit". "Thanked" should appear disabled with the light gray disabled color, which is #CCC for a disabled quiet button like Preview (class="mw-ui-button mw-ui-quiet" disabled="disabled"). This is a regression, see
https://trello-attachments.s3.amazonaws.com/52cb2bb5b4f69841496a78fd/53a9bb9f7f51873704c4bfe3/177x36/2eace562b77cd752677564abd02f2827/Flow_thank.gif

Adding the disabled attribute to a span is improper HTML. I guess we could have class=mw-ui-disabled . The LSG section for Text and anchors http://tools.wmflabs.org/styleguide/desktop/section-6.html doesn't give examples of disabled text/anchors , its should.

Version: master
Severity: enhancement

Details

Reference
bz69633

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
• bzimport added projects: StructuredDiscussions, Design.
• bzimport set Reference to bz69633.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Aug 15 2014, 11:54 PM
• DannyH added a comment.Aug 21 2014, 5:15 PM

in backlog: https://trello.com/c/kysfhuWe

Jdlrobson added a comment.Sep 9 2014, 2:33 AM

mw-ui-disabled doesn't exist.
Anchor links cannot be disabled (which makes me wonder if there is a button)
This requires more thought.

Should edit, reply and thank all be mw-ui-active and become mw-ui-quiet when disabled?
Also when are we going to introduce click again to undo?

Adding design tag as this needs some more thought and in current form is too vague.

EBernhardson closed this task as Resolved.Dec 12 2014, 12:24 AM
EBernhardson triaged this task as Medium priority.
EBernhardson set Security to None.
EBernhardson added a comment.Dec 12 2014, 12:26 AM

Currently the anchors are #666, the 'Thanked' text is a span that resolves to #898989 which is the default text color of the .flow-post-meta box it is inside. This seems reasonable and addresses the issue of same color for disabled link(its also not a link anymore, just a span).

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:25 AM
Quiddity removed a subscriber: • violetto.Dec 19 2014, 1:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL