Page MenuHomePhabricator

Input blue indicators look strange when rounded corners are applied to mediawiki ui inputs
Closed, DeclinedPublic

Description

Login form on mobile site on beta labs (viewed in desktop Chrome)

On beta labs, the blue input indicator has begun to appear on the login & account creation form fields on the mobile site; however, since those fields have rounded corners on mobile and the input indicator evidently expects the square fields that are present on desktop, there's an awkward gap around the edges (see attached screenshot). There also appears to be some padding missing between the indicator and the input text, because it's quite close & crowded -- and imho the padding isn't entirely ideal on desktop, either :)


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz69724

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:42 AM
bzimport set Reference to bz69724.
bzimport added a subscriber: Unknown Object (MLST).
Maryana created this task.Aug 18 2014, 10:51 PM

I think the solution to this is to stop using a different login page for mobile.
Currently mobile rewrites the login page. We shouldn't have to do this any more.

The problem with the rendering is mobile styles input fields slightly different on this page e.g. rounded corners. We will need to change code in mobile or update the spec in core to change how this should render in mobile.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nxvLBVNW

gerritadmin wrote:

Change 154979 had a related patch set uploaded by Jdlrobson:
Remove rounded corners on login form to get more login form consistency

https://gerrit.wikimedia.org/r/154979

gerritadmin wrote:

Change 154979 abandoned by Jdlrobson:
Remove rounded corners on login form to get more login form consistency

Reason:
Apparently this is not a big deal so abandoning.

https://gerrit.wikimedia.org/r/154979

I agree with Jon here.

gerritadmin wrote:

Change 165634 had a related patch set uploaded by Florianschmidtwelzow:
Use desktop login/account creation form in alpha

https://gerrit.wikimedia.org/r/165634

The new focus state designed by May should resolve this problem. There is a patch that introduces this change - I24f33a40cd0126ae95698c2a46858a15f502ca5b

This actually looks fine now.

gerritadmin wrote:

Change 165634 merged by jenkins-bot:
Use desktop login/account creation form in alpha

https://gerrit.wikimedia.org/r/165634