I think that is handled by deployment-upload.eqiad.wmflabs which is more or less a simulation of the old media servers using nginx. IIRC thumb.php got copied there a while ago and never got updated.

In T71757#746442, @hashar wrote:

I think that is handled by deployment-upload.eqiad.wmflabs which is more or less a simulation of the old media servers using nginx. IIRC thumb.php got copied there a while ago and never got updated.

Is that not supposed to be auto updated with the rest of the codebase? cc'ing @Reedy for how it's done in prod.

The instance deployment-upload has been put in a hurry by someone (can't remember). Whatever thumb.php code is there is most probably terribly outdated.

Someone needs to recreate deployment-upload entirely and have it properly puppetized and kept up to date automatically.

I am not volunteering, our thumbnail infrastructure scares me.

@hashar, tell you the truth, I don't know myself how new code is deployed to betacluster, especially entry points - its all pretty scary to me too )

In T71757#1659794, @Yurik wrote:

@hashar, tell you the truth, I don't know myself how new code is deployed to betacluster, especially entry points - its all pretty scary to me too )

It's not scary at all:

• Jenkins runs a job every 10 minutes: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/
  • Which includes a scap run: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/
• Config update on change: https://integration.wikimedia.org/ci/view/Beta/job/beta-mediawiki-config-update-eqiad/
• Database updates (update.php) every hour: https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/

In T71757#1659794, @Yurik wrote:

@hashar, tell you the truth, I don't know myself how new code is deployed to betacluster, especially entry points - its all pretty scary to me too )

Also, to be clear: claiming ignorance is not going to be a successful long term collaboration method. Beta Cluster maintenance is everyone's responsibility. 6 people in RelEng can't know how all of the software 130 full-time engineers create works.

@greg, this is awesome list of links! (is it posted on wikitech somewhere?). When scap and config updates run, do they include the entry points such as thumb.php, or is it only for the config updates? Also, the proper word is not "ignorance", its "fear" ;)

In T71757#1659844, @Yurik wrote:

@greg, this is awesome list of links! (is it posted on wikitech somewhere?). When scap and config updates run, do they include the entry points such as thumb.php, or is it only for the config updates? Also, the proper word is not "ignorance", its "fear" ;)

https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated

Take a look, it's all there in the code :) You're a smart developer.

Thumbnail entry points are not deployed, they are just there. See the blocked task.

I believe we would need T64835: Setup a Swift cluster on beta-cluster to match production as a prerequisite to overhaul the Beta cluster thumbnail system.

Sorry for the mess in the blocked-by/blocking. The dependency tree is now:

• This bug: T71757: Images with extra parameters (e.g. low-quality JPEG) are not rendered in beta
  • T84950: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking)
    • T64835: Setup a Swift cluster on beta-cluster to match production

Change 256589 had a related patch set uploaded (by Gergő Tisza):
Fix upload rewrite rules for beta

https://gerrit.wikimedia.org/r/256589

Change 256589 merged by Ori.livneh:
Fix upload rewrite rules for beta

https://gerrit.wikimedia.org/r/256589