Page MenuHomePhabricator

BetaFeatures: Settings pane looks ugly with JavaScript disabled
Closed, ResolvedPublic

Description

Author: gryllida

Description:
Beta Features without JavaScript. Ugly picture. Text is overlapping.

[[File:BetaFeatures_without_JavaScript.png]]


Version: unspecified
Severity: normal

Attached:

BetaFeatures_without_JavaScript.png (584×968 px, 46 KB)

Details

Reference
bz69778

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:27 AM
bzimport added a project: BetaFeatures.
bzimport set Reference to bz69778.

Confirmed. Some (all?) of the styles are being delivered via JavaScript (e.g. the requirements text is red only with JS, plus probably some structural CSS).

However, the page is intended to work without JS, as confirmed by it even saying which features require JS. That means those parts of the styles that make sense for no-JS browsers should be delivered via addModuleStyles.

gerritadmin wrote:

Change 161694 had a related patch set uploaded by Bartosz Dziewoński:
Provide styles when JavaScript is disabled

https://gerrit.wikimedia.org/r/161694

gerritadmin wrote:

Change 161694 merged by jenkins-bot:
Provide styles when JavaScript is disabled

https://gerrit.wikimedia.org/r/161694

Thanks a lot! From ugly without JS, it is now as beautiful as with JS.