Page MenuHomePhabricator

BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences
Closed, ResolvedPublic

Description

I'm not sure why, but wgBetaFeaturesFeatures is incomplete on my local MediaWiki-Vagrant install.

In the actual preferences UI, I see the following BetaFeatures:

  • Hovercards
  • Compact personal bar
  • Fixed header
  • VisualEditor
  • VisualEditor language tool

But wgBetaFeaturesFeatures is only:

{ popups: null, visualeditor-enable-language: null }

That in turn means that these are the only ones looped over in betafeatures.js, which means other features don't have the JavaScript/browser blacklist processing.

This bug affects production as well.

Side note, you can use:

.client-js .mw-ui-feature-requirements-javascript {

display: none;

}

for a simpler way to do the JS-hiding, but that doesn't address the underlying problem.


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=70371

Details

Reference
bz69823

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:30 AM
bzimport added a project: BetaFeatures.
bzimport set Reference to bz69823.

gerritadmin wrote:

Change 159538 had a related patch set uploaded by Jforrester:
Populate $features even if there aren't any requirements

https://gerrit.wikimedia.org/r/159538

This bug is a consequence of bug 70814, see https://bugzilla.wikimedia.org/show_bug.cgi?id=70814#c5 : the fix there correctly populates the wgBetaFeaturesFeatures array. (I make this bug depend of bug 70814, but it is similar to a duplicate.)

https://gerrit.wikimedia.org/r/161629 should have resolved this bug. Is it confirmed?

gerritadmin wrote:

Change 159538 merged by jenkins-bot:
Populate $features even if there aren't any requirements

https://gerrit.wikimedia.org/r/159538

Underlying issue is only fixed by James's patch, but Seb35's patch has already fixed the display for the beta features I tested.

(In reply to Matthew Flaschen from comment #0)

Side note, you can use:
.client-js .mw-ui-feature-requirements-javascript {

display: none;

}
for a simpler way to do the JS-hiding, but that doesn't address the
underlying problem.

Done in https://gerrit.wikimedia.org/r/161690