Page MenuHomePhabricator

Remove 'apiScript' from $wgResourceLoaderSources
Closed, ResolvedPublic

Description

When $wgResourceLoaderSources was introduced, it required two keys, one for the load.php location, and another for the api.php endpoint. However, RL only actually uses the load.php location. The api part is unused, except for usage in ForeignAPIGadgetRepo in Gadgets 2.0.

I think it's inappropriate to have 'apiScript' in the core config, especially if nearly nothing uses it. The API link should be moved to a Gadgets configuration setting.


Version: 1.24rc
Severity: normal

Details

Reference
bz69878

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz69878.
bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Aug 22 2014, 12:22 AM

(In reply to Kunal Mehta (Legoktm) from comment #0)

When $wgResourceLoaderSources was introduced, it required two keys, one for
the load.php location, and another for the api.php endpoint.

Minor correction, it doesn't require both, just 'loadScript'. However the documentation in DefaultSettings.php did make it seem like it was.

Change 156083 had a related patch set uploaded by Legoktm:
ResourceLoader: Only store sources' load.php urls

https://gerrit.wikimedia.org/r/156083

Change 156083 merged by jenkins-bot:
resourceloader: Only store sources' load.php urls

https://gerrit.wikimedia.org/r/156083

So it's now gone from core, which has presumably broken Gadgets 2.0...

All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?