Page MenuHomePhabricator

VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc
Closed, ResolvedPublic

Description

In MWLinkTargetInputWidget and other places, we perform API requests that give us exactly the kind of information (existence, redirect status, etc.) that goes into ve.init.mw.LinkCache, but we don't write it to the link cache. We should do that, so we can save ourselves some API requests.

Right now, when you make a link, we do another API request to check if the link should be blue or red, even if the link target came from a suggestion list and we already know it should be blue.


Version: unspecified
Severity: enhancement

Details

Reference
bz69886

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:34 AM
bzimport set Reference to bz69886.
Catrope created this task.Aug 22 2014, 6:24 AM

Change 156955 had a related patch set uploaded by Alex Monk:
In LinkTargetInputWidget, put existence status into LinkCache

https://gerrit.wikimedia.org/r/156955

Change 156955 merged by jenkins-bot:
In LinkTargetInputWidget, put existence status into LinkCache

https://gerrit.wikimedia.org/r/156955

Do we want to do this from MWTitleInputWidget and MWCategoryInputWidget?

(In reply to James Forrester from comment #3)

Do we want to do this from MWTitleInputWidget and MWCategoryInputWidget?

Re-opening after discussing with Roan.

Change 159418 had a related patch set uploaded by Alex Monk:
Update LinkCache in MWTitleInputWidget

https://gerrit.wikimedia.org/r/159418

Change 159418 merged by jenkins-bot:
Update LinkCache in MWTitleInputWidget

https://gerrit.wikimedia.org/r/159418

Now just waiting for category existence checking, I believe?

Change 159623 had a related patch set uploaded by Alex Monk:
Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten

https://gerrit.wikimedia.org/r/159623

Change 159623 merged by jenkins-bot:
Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten

https://gerrit.wikimedia.org/r/159623