Log always says "sent to 0 recipients"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nemo_bis
	Aug 22 2014, 7:19 AM

Description

Since May, all the log entries claim that the notifications were "sent to 0 recipients":
https://meta.wikimedia.org/w/index.php?title=Special:Log&offset=20140822065925&limit=15&type=notifytranslators&uselang=en

For instance:
02:09, 19 August 2014 Thehelpfulone (talk | contribs) sent a notification about translating page Mailing lists/List info; languages: all languages; deadline: none; priority: medium; sent to 0 recipients, failed for 1778 recipients, skipped for 0 recipients

But we know for a fact that the notifications were actually sent. I checked a smaller notification to a few hundreds users and it would seem that the number of "skipped" users is close to the number of notified users. So it might just be a trivial error in the order of parameters somewhere.

Maybe related to the changes mentioned in bug 54956 comment 4?

Version: unspecified
Severity: normal
URL: https://meta.wikimedia.org/w/index.php?title=Special:Log&offset=20140822065925&limit=15&type=notifytranslators&uselang=en

Details

Reference: bz69887

	Subject	Repo	Branch	Lines +/-
	Fix log entries saying 0 recipients were notified	mediawiki/extensions/TranslationNotifications	master	+4 -10

Customize query in gerrit

Related Objects

Mentioned In: rETRN45ffdec445a5: Fix log entries saying 0 recipients were notified
rMEXTbef57741248a: Updated mediawiki/extensions Project…

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:34 AM

• bzimport added a project: TranslationNotifications.

• bzimport set Reference to bz69887.

• bzimport added a subscriber: Unknown Object (MLST).

Nemo_bis created this task.Aug 22 2014, 7:19 AM

Restoring minor: "Minor loss of function, or other problem that does not affect many people or where an easy workaround is present."

There isn't any workaround and thousands people are affected.

Please do not touch the severity or importance fields. Only the people sending out notifications (or reading the logs) are affected. If they know about this bug report, then they know to ignore the wrong information.

Glaisher merged a task: T78528: Error in log messages (Special:Log/notifytranslators).Jan 10 2015, 12:55 PM

Glaisher added subscribers: Aklapper, MarcoAurelio.

Nikerabbit added a project: Language-Team.Jan 10 2015, 8:04 PM

In T71887#729459, @Nikerabbit wrote:

Please do not touch the severity or importance fields. Only the people sending out notifications (or reading the logs) are affected. If they know about this bug report, then they know to ignore the wrong information.

Yeah... but we don't all know about the bug :( I just double sent a notification to everyone because it looked like it had completely failed. I probably would have thought about a 3rd even (though at that point I would have started wondering about a much larger bug) if I hadn't checked the bot recent changes quickly.

Stryn subscribed.Apr 17 2015, 12:05 PM

Nemo_bis raised the priority of this task from Medium to High.Apr 18 2015, 10:21 PM

Legoktm claimed this task.Apr 18 2015, 10:25 PM

Change 205064 had a related patch set uploaded (by Legoktm):
Fix log entries saying 0 recipients were notified

https://gerrit.wikimedia.org/r/205064

gerritbot added a project: Patch-For-Review.Apr 18 2015, 10:32 PM

Change 205064 merged by jenkins-bot:
Fix log entries saying 0 recipients were notified

https://gerrit.wikimedia.org/r/205064

Legoktm mentioned this in rMEXTbef57741248a: Updated mediawiki/extensions Project….Apr 21 2015, 7:05 AM

Legoktm closed this task as Resolved.Apr 21 2015, 7:05 AM

Legoktm mentioned this in rETRN45ffdec445a5: Fix log entries saying 0 recipients were notified.Apr 21 2015, 7:05 AM

Looks good now. Thanks! https://meta.wikimedia.org/w/index.php?title=Special:Log&offset=20150505000000&limit=1&type=notifytranslators&uselang=en