Page MenuHomePhabricator

2.0: Make it clearer that Scripts and CSS must be in Gadget namespace when defining a gadget
Closed, ResolvedPublic

Description

I enabled gadgets2 role on Vagrant and when I clicked in the "Create" link in the top of
http://127.0.0.1:8080/wiki/Special:Gadgets
it loaded a popup named "Creating a new gadget". In that popup there is a field "Script" in the section "Module properties".

For a user using Gadgets 2.0 for the first time, it will not be clear what name should be typed there:

  • MediaWiki:Gadget-foo.js (incorrect - this is the naming convention from 1.0)
  • Gadget-foo.js (incorrect - this is the naming convention from 1.0)
  • Foo.js (correct, but the page needs to exist first, or it will be ignored!)
  • Gadget:Foo.js (incorrect - even if the page exists, it will be ignored)

The only case where the autocomplete feature works is when [[Gadget:Foo.js]] exists and the user types (a substring of) "Foo.js". This is not very user friendly.

Maybe there should be a placeholder as the default value, and a link to the namespace somewhere (to allow the user to find existing JS pages which can be used).

Same problems for CSS.


Version: unspecified
Severity: normal

Details

Reference
bz69906

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:35 AM
bzimport set Reference to bz69906.

(In reply to Helder from comment #0)

  • Foo.js (correct, but the page needs to exist first, or it will be ignored!)
  • Gadget:Foo.js (incorrect - even if the page exists, it will be ignored)

I think we should accept both of these.

Maybe there should be a placeholder as the default value, and a link to the
namespace somewhere (to allow the user to find existing JS pages which can
be used).

I'm thinking "Existing title in the Gadget namespace" for the placeholder. Is that enough?

(In reply to Alex Monk from comment #1)
I agree.

gerritadmin wrote:

Change 157628 had a related patch set uploaded by Alex Monk:
Clarify what the 'scripts' and 'styles' fields in the gadget manager should contain

https://gerrit.wikimedia.org/r/157628

gerritadmin wrote:

Change 157628 merged by jenkins-bot:
Clarify what the 'scripts' and 'styles' fields in the gadget manager should contain

https://gerrit.wikimedia.org/r/157628