Page MenuHomePhabricator

Flow SQL queries breaks DebugToolbar
Open, NormalPublic

Description

Enable https://www.mediawiki.org/wiki/Debugging_toolbar , visit a Flow board.
Some developers (using zend PHP not HHVM) get a JS error. Appending ?debug=1 reveals mediawiki.debug.js fails accessing this.data.log because this.data is null.

We think it's because Flow's SQL queries of binary(11) columns involve strings like "�#�����o~p". Shahyar Ghobadpour found that in his case the PHP conversion to JSON fails so the expected data structure isn't present. He has a gerrit patch https://gerrit.wikimedia.org/r/#/c/155832/

Details

Reference
bz69926

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:37 AM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz69926.
bzimport added a subscriber: Unknown Object (MLST).

Change 155832 had a related patch set uploaded by Legoktm:
Fix malformed UTF-8 going to query profiler

https://gerrit.wikimedia.org/r/155832

Change 155832 merged by jenkins-bot:
Fix malformed UTF-8 going to query profiler

https://gerrit.wikimedia.org/r/155832

All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

matej_suchanek edited projects, added TestMe; removed Patch-For-Review.
matej_suchanek set Security to None.
matej_suchanek removed a subscriber: wikibugs-l-list.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptFeb 10 2017, 6:53 AM