Page MenuHomePhabricator
Create Task
Maniphest T71928

Flow: the external link CAPTCHA for a reply appears in wrong place, doesn't work
Closed, ResolvedPublic
Actions

Description

Flow topic reply CAPTCHA in wrong place

I replied to a topic on User_talk:Quiddity on ee-flow.wmflabs.org.
Because my post had external links, it displayed a CAPTCHA. But

  • The CAPTCHA displays in the topic titlebar (see attachment). It should display in the post form (class='flow-post flow-reply-form').
  • Because it's not in the post form, your solution to the CAPTCHA solution isn't submitted, so you can never reply until you remove the link.

I haven't tried reproducing on other servers. ee-flow's antispam configuration is different.

Version: master
Severity: normal

Attached:

Flow_reply_CAPTCHA_located_in_topic_titlebar.png (683×654 px, 73 KB)

Details

Reference
bz69928

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:37 AM
• bzimport added projects: StructuredDiscussions, good first task.
• bzimport set Reference to bz69928.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Aug 22 2014, 11:39 PM
Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:41 AM
blackops0057 subscribed.EditedDec 19 2014, 6:09 PM

HI I'd like to work on this bug. I'm a beginner. How do i begin fixing it? I have the source code ready

Quiddity closed this task as Resolved.Dec 19 2014, 7:14 PM
Quiddity claimed this task.

This seems to have been fixed at some point, but without an attached patch (/me grumbles). I just tested at mediawiki, and the captcha appeared in the right place, and was functional.

Thanks for the enthusiasm though! I hope you can find another bug that interests you. Docs on how to best contribute, and where to ask questions, are at https://www.mediawiki.org/wiki/How_to_contribute

Quiddity removed Quiddity as the assignee of this task.Dec 19 2014, 7:14 PM
Quiddity set Security to None.
• Mattflaschen-WMF triaged this task as High priority.Dec 19 2014, 7:18 PM
• Mattflaschen-WMF subscribed.
In T71928#936602, @blackops0057 wrote:

HI I'd like to work on this bug. I'm a beginner. How do i begin fixing it? I have the source code ready

Do you have Flow set up to run locally yet? If not, try MediaWiki-Vagrant.

Also, you should join our IRC channel, #wikimedia-collaboration on Freenode (IRC web interface), if possible.

blackops0057 added a comment.Dec 20 2014, 11:13 AM
In T71928#936748, @Mattflaschen wrote:
In T71928#936602, @blackops0057 wrote:

HI I'd like to work on this bug. I'm a beginner. How do i begin fixing it? I have the source code ready

Do you have Flow set up to run locally yet? If not, try MediaWiki-Vagrant.

Also, you should join our IRC channel, #wikimedia-collaboration on Freenode (IRC web interface), if possible.

I'm setting up flow right now. And i have joined #wikimedia-collaboration IRC channel !

TTO subscribed.Dec 20 2014, 11:43 AM

This bug is fixed (see Quiddity's comment), so there is no need to work on it :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL