Page MenuHomePhabricator

Deprecate mw.translateHooks in favour of mw.hook
Open, NormalPublic

Description

Since we now depend on MediaWiki 1.22 or newer, we can use the core hook facility instead of shipping our own.

Details

Reference
bz70031

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz70031.
bzimport added a subscriber: Unknown Object (MLST).

We probably want to keep the public functions since TranslateSVG is using them, but have them throw deprecation warnings.

Nikerabbit updated the task description. (Show Details)
Nikerabbit removed a subscriber: wikibugs-l-list.
abi_ moved this task from Backlog to In Progress on the User-abi_ board.Apr 17 2019, 9:29 AM

Change 505275 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Remove usage of mw.transateHook across the Translate extension

https://gerrit.wikimedia.org/r/505275

Change 505277 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/TranslateSvg@master] Remove mw.translateHook and use mw.hook instead.

https://gerrit.wikimedia.org/r/505277

abi_ moved this task from In Progress to Under Review on the User-abi_ board.Apr 20 2019, 7:11 AM
abi_ added a subscriber: abi_.

Moving this to under review.

  • Update the code in Translate and TranslateSvg extension to use mw.hook instead of mw.translateHook.
  • Removed code in TranslateSvg extension that used the afterRegisterFeatures hook.
  • Updated a few test cases in Translate and TranslateSvg extension.
abi_ claimed this task.Apr 20 2019, 8:29 AM

Change 505275 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Replace usage of mw.translateHook with mw.hook

https://gerrit.wikimedia.org/r/505275

Change 505277 merged by jenkins-bot:
[mediawiki/extensions/TranslateSvg@master] Replace usage of mw.translateHook with mw.hook

https://gerrit.wikimedia.org/r/505277

abi_ moved this task from Under Review to QA on the User-abi_ board.Tue, May 7, 9:24 AM
abi_ removed a project: Patch-For-Review.

Moving this to the correct column.